Skip to content

Commit be47edc

Browse files
committed
Merge pull request #39 from launchdarkly/pk/events_uri
added config option for events_uri
2 parents 7bf786b + 3c8f140 commit be47edc

File tree

5 files changed

+7
-4
lines changed

5 files changed

+7
-4
lines changed

ldclient/client.py

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -25,6 +25,7 @@ class Config(object):
2525

2626
def __init__(self,
2727
base_uri='https://app.launchdarkly.com',
28+
events_uri='https://events.launchdarkly.com',
2829
connect_timeout=2,
2930
read_timeout=10,
3031
upload_limit=100,
@@ -54,6 +55,7 @@ def __init__(self,
5455
defaults = {}
5556

5657
self.base_uri = base_uri.rstrip('\\')
58+
self.events_uri = events_uri.rstrip('\\')
5759
self.stream_uri = stream_uri.rstrip('\\')
5860
self.stream = stream
5961
self.stream_processor_class = RequestsStreamProcessor if not stream_processor_class else stream_processor_class

ldclient/requests.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -127,7 +127,7 @@ def do_send(should_retry):
127127
else:
128128
body = events
129129
hdrs = _headers(self._api_key)
130-
uri = self._config.base_uri + '/api/events/bulk'
130+
uri = self._config.events_uri + '/bulk'
131131
r = self._session.post(uri, headers=hdrs, timeout=(self._config.connect, self._config.read),
132132
data=json.dumps(body))
133133
r.raise_for_status()

ldclient/twisted_impls.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -149,7 +149,7 @@ def do_send(should_retry):
149149
else:
150150
body = events
151151
hdrs = _headers(self._api_key)
152-
uri = self._config.base_uri + '/api/events/bulk'
152+
uri = self._config.events_uri + '/bulk'
153153
r = yield self._session.post(uri, headers=hdrs, timeout=(self._config.connect, self._config.read),
154154
data=json.dumps(body))
155155
r.raise_for_status()

testing/server_util.py

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -88,6 +88,7 @@ def do_nothing(handler):
8888
handler.end_headers()
8989

9090
self.post_paths["/api/events/bulk"] = do_nothing
91+
self.post_paths["/bulk"] = do_nothing
9192
return q
9293

9394
def add_feature(self, key, data):

testing/test_integration.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -32,14 +32,14 @@ def fin():
3232

3333
def test_toggle(server):
3434
server.add_feature("foo", feature("foo", "jim")['foo'])
35-
client = LDClient("apikey", Config(base_uri=server.url))
35+
client = LDClient("apikey", Config(base_uri=server.url, events_uri=server.url))
3636
wait_until(lambda: client.toggle("foo", user('xyz'), "blah") == "jim")
3737

3838

3939
def test_sse_init(server, stream):
4040
stream.queue.put(Event(event="put", data=feature("foo", "jim")))
4141
client = LDClient("apikey", Config(
42-
stream=True, base_uri=server.url, stream_uri=stream.url))
42+
stream=True, base_uri=server.url, events_uri=server.url, stream_uri=stream.url))
4343
wait_until(lambda: client.toggle("foo", user('xyz'), "blah") == "jim")
4444

4545

0 commit comments

Comments
 (0)