Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the dynamic test name in the scheduled workflow #21

Closed
pottekkat opened this issue Nov 12, 2021 · 9 comments
Closed

Update the dynamic test name in the scheduled workflow #21

pottekkat opened this issue Nov 12, 2021 · 9 comments
Assignees
Labels
area/ci Continuous integration | Build and release issue/remind kind/enhancement Improvement in current feature

Comments

@pottekkat
Copy link
Contributor

Current Behavior

The Scheduled Benchmark Tests workflow creates dynamic test names based on the configuration of the test. Current format is shown below.

https://github.com/layer5io/meshery-smp-action/blob/b999f0aec563c79590a640050e8d691315116582/.github/workflows/scheduled-benchmarks.yml#L59

So, a sample test name now is: istio-fortio-load-test.yaml

Desired Behavior

Remove the .yaml from the test name and only include the rest of the file name.


Contributor Guide

@pottekkat pottekkat added area/ci Continuous integration | Build and release kind/enhancement Improvement in current feature labels Nov 12, 2021
@pottekkat
Copy link
Contributor Author

@varunsaral
Copy link

Please assign me this

@pottekkat
Copy link
Contributor Author

Sure. Here you go.

@piyushsingariya
Copy link
Member

Hey @varunsaral checking in if you're still working on this??

@varunsaral
Copy link

yes @piyushsingariya i'm working on it , we can connect on slack if you want to discuss about it.

@piyushsingariya
Copy link
Member

Sure, I'm excited to see some work on this.

@stale
Copy link

stale bot commented Mar 25, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the issue/stale Issue has not had any activity for an extended period of time label Mar 25, 2022
@gyohuangxin
Copy link
Member

I will implement this in my PR about scheduled benchmark on self-hosted runner.

@stale stale bot removed the issue/stale Issue has not had any activity for an extended period of time label Mar 25, 2022
@gyohuangxin gyohuangxin self-assigned this Mar 25, 2022
@gyohuangxin
Copy link
Member

PR merged, close it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/ci Continuous integration | Build and release issue/remind kind/enhancement Improvement in current feature
Development

No branches or pull requests

4 participants