Ensure that Istio application endpoint is reachable from Meshery #28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Xin Huang <[email protected]>
leecalcote
requested review from
piyushsingariya,
s1ntaxe770r and
DelusionalOptimist
|
@navendu-pottekkat I've tested it and it works, can you review this? Thanks. |
|
@sunkuranganath fyi |
pottekkat
approved these changes
Dec 1, 2021
There was a problem hiding this comment.
Thank you for the fix @gyohuangxin 🚀
Looks good to me. I missed the /productpage path as well!
|
Thank you @gyohuangxin ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Xin Huang [email protected]
Description
This PR fixes #27
minikube tunnelcommand withminikube tunnel &> /dev/null &to avoid the tunnel getting killed.Signed commits