Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run scheduled benchmarks on different sample applications #33

Closed
pottekkat opened this issue Dec 13, 2021 · 13 comments
Closed

Run scheduled benchmarks on different sample applications #33

pottekkat opened this issue Dec 13, 2021 · 13 comments
Assignees
Labels
area/ci Continuous integration | Build and release issue/stale Issue has not had any activity for an extended period of time kind/enhancement Improvement in current feature

Comments

@pottekkat
Copy link
Contributor

Current Behavior

Currently the tests are run with the sample application of the particular service mesh. This is different for each service mesh.

Desired Behavior

Add sample application as a configurable item and run tests across multiple applications for each service mesh.

A new field should be added here and the scripts needs to be changed to take in this dynamic value.


Contributor Guide

@pottekkat pottekkat added area/ci Continuous integration | Build and release kind/enhancement Improvement in current feature labels Dec 13, 2021
@pottekkat
Copy link
Contributor Author

pottekkat commented Dec 13, 2021

Issue opened from a discussion on comments #27 (comment) and #27 (comment).

@gyohuangxin
Copy link
Member

gyohuangxin commented Dec 14, 2021

@navendu-pottekkat Thank you! Do we have the list of sample applications to choose and scripts to install them?

@pottekkat
Copy link
Contributor Author

We do have sample applications within Meshery but those functionalities aren't available in the CLI yet. We are working on a design specification to add those features.

We do want to use mesheryctl to deploy sample apps if we can or we can come back later and change the script to use mesheryctl.

mesheryctl app onboard file.yaml should work here.

Here is the list of sample apps we use currently.

@pottekkat
Copy link
Contributor Author

But for now, we can start with Bookinfo and Emojivoto from Istio and Linkerd. These scripts are already present.

@gyohuangxin
Copy link
Member

@navendu-pottekkat Thanks, I see.
I have another confusing question, the mershery perf will failed when my github token expire after some hours, and I have to get the new token from Meshery UI and re-update my token in github repo. Any way to have a permanent token?

@pottekkat
Copy link
Contributor Author

Great question. We added indefinite tokens just recently for this use case within CI/CD. Let me share the details over Slack.

@stale
Copy link

stale bot commented Jan 28, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the issue/stale Issue has not had any activity for an extended period of time label Jan 28, 2022
@leecalcote
Copy link
Member

@asubedy, up for this?

@stale stale bot removed the issue/stale Issue has not had any activity for an extended period of time label Jan 29, 2022
@asubedy
Copy link
Member

asubedy commented Jan 29, 2022

Yes I will try to work on this.

Before starting @navendu-pottekkat wanted to make few things clear:
So we are trying to check performance of the application say for example bookinfo deployed on other service mesh too like Linkerd and osm and not just on Istio. So for this we need to edit the current scripts of each service mesh to accommodate these different/dynamic application test.

Please correct me if I am wrong.

@leecalcote
Copy link
Member

@asubedy yes, that's right.

@asubedy asubedy self-assigned this Jan 30, 2022
@asubedy
Copy link
Member

asubedy commented Jan 30, 2022

Yes ok I'll try this.

@stale
Copy link

stale bot commented Mar 17, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the issue/stale Issue has not had any activity for an extended period of time label Mar 17, 2022
@stale
Copy link

stale bot commented Mar 28, 2022

This issue is being automatically closed due to inactivity. However, you may choose to reopen this issue.

@stale stale bot closed this as completed Mar 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/ci Continuous integration | Build and release issue/stale Issue has not had any activity for an extended period of time kind/enhancement Improvement in current feature
Development

No branches or pull requests

4 participants