Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Meshes: Kuma, App Mesh, Consul, Cilium #52

Closed
wants to merge 9 commits into from

Conversation

gyohuangxin
Copy link
Member

Signed-off-by: Huang Xin [email protected]

Description

This PR fixes #51

Notes for Reviewers

Signed commits

  • Yes, I signed my commits.

@leecalcote
Copy link
Member

Ready to try this out?

@leecalcote leecalcote added the area/performance Performance management label May 19, 2022
@gyohuangxin
Copy link
Member Author

@leecalcote Yes, I'm working on it. One question is that no every service mesh has its own demo apps, I found Kuma has one but app mesh, consul and cilium may not. Can we use Istio's bookinfo app as a alternative?

@hershd23
Copy link
Contributor

hershd23 commented Jun 9, 2022

@leecalcote Yes, I'm working on it. One question is that no every service mesh has its own demo apps, I found Kuma has one but app mesh, consul and cilium may not. Can we use Istio's bookinfo app as a alternative?

Yep I tried this exercise for Cilium and Consul and both of them do not have a sample app, atleast nothing like bookinfo or emojivoto for istio and linkerd

@leecalcote should we try creating some simple applications?

@hershd23
Copy link
Contributor

hershd23 commented Jun 9, 2022

Got this for consul :- https://github.com/hashicorp/learn-consul-k8s-hashicups/tree/main/hashicups

I guess this might work. This is a pattern divided into 4 files. Apparently we might have to append these files into one and then apply the pattern.

This came out in todays CI meeting. To be specific out of @Zanda256 and @Revolyssup 's conversation. All credits to them

@hershd23
Copy link
Contributor

hershd23 commented Jun 9, 2022

Another thought, is it worth making one common pattern, say bookinfo for all service mesh adapters. This gives us a common pattern to test for SMP.... if that's something we want

@Zanda256
Copy link

Zanda256 commented Jun 9, 2022

This will be a lot of heavy lifting. Maybe for cilium, since it's a new project and the makers haven't released a sample app yet.

@gyohuangxin
Copy link
Member Author

Another thought, is it worth making one common pattern, say bookinfo for all service mesh adapters. This gives us a common pattern to test for SMP.... if that's something we want

@hershd23 Yes, I think we should. I will try mesheryctl pattern apply instead of mesheryctl app aboard. In the future, we should make it configurable.

Signed-off-by: Huang Xin <[email protected]>
Signed-off-by: Huang Xin <[email protected]>
Signed-off-by: Huang Xin <[email protected]>
Signed-off-by: Huang Xin <[email protected]>
@gyohuangxin
Copy link
Member Author

I failed to deploy app-mesh and cilium adapters,

  • For app-mesh adapter, I use command mesheryctl mesh deploy adapter meshery-app-mesh:10000 --token "./.github/workflows/auth.json", but it will never choose to deploy app-mesh in console:
Failed to open Meshery in browser, please point your browser to http://192.168.49.2:31552/ to access Meshery.
Verifying prerequisites...
25l
Use the arrow keys to navigate:↓↑→←
? Select a Service Mesh from the list: 
▸LINKERD
    CONSUL
    KUMA
    OPEN_SERVICE_MESH
↓   NGINX_SERVICE_MESH
Use the arrow keys to navigate:↓↑→←
? Select a Service Mesh from the list: 
▸LINKERD
    CONSUL
    KUMA
    OPEN_SERVICE_MESH
↓   NGINX_SERVICE_MESH
Use the arrow keys to navigate:↓↑→←
? Select a Service Mesh from the list: 
▸LINKERD
    CONSUL
    KUMA
    OPEN_SERVICE_MESH
↓   NGINX_SERVICE_MESH
✔LINKERD

https://github.com/gyohuangxin/meshery-smp-action/runs/7183605286?check_suite_focus=true#step:4:88

@leecalcote Do you have any ideas, is my command wrong?

@stale
Copy link

stale bot commented Sep 9, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the issue/stale Issue has not had any activity for an extended period of time label Sep 9, 2022
@stale
Copy link

stale bot commented Sep 20, 2022

This issue is being automatically closed due to inactivity. However, you may choose to reopen this issue.

@stale stale bot closed this Sep 20, 2022
@leecalcote leecalcote reopened this Sep 20, 2022
@stale stale bot removed the issue/stale Issue has not had any activity for an extended period of time label Sep 20, 2022
@leecalcote
Copy link
Member

Still in draft?

@stale
Copy link

stale bot commented Nov 12, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the issue/stale Issue has not had any activity for an extended period of time label Nov 12, 2022
@stale
Copy link

stale bot commented Nov 22, 2022

This issue is being automatically closed due to inactivity. However, you may choose to reopen this issue.

@stale stale bot closed this Nov 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/performance Performance management issue/stale Issue has not had any activity for an extended period of time
Development

Successfully merging this pull request may close these issues.

Enable other service meshes performance tests
4 participants