Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename the profiles of performance tests #59

Closed
gyohuangxin opened this issue Aug 3, 2022 · 15 comments
Closed

Rename the profiles of performance tests #59

gyohuangxin opened this issue Aug 3, 2022 · 15 comments
Labels
kind/enhancement Improvement in current feature

Comments

@gyohuangxin
Copy link
Member

Current Behavior

Performance test profiles are named as {service-mesh}-{load-generator}-{test-configuration}.yaml currently, it‘s ugly and hard to understand.
image

The goal of this issue is to discuss and find out the how to make the profile names be in order for people to understand what is being tested.

@gyohuangxin gyohuangxin added the kind/enhancement Improvement in current feature label Aug 3, 2022
@gyohuangxin
Copy link
Member Author

@leecalcote @hershd23

@leecalcote
Copy link
Member

Perfect. @asubedy is here to assist.

@hershd23
Copy link
Contributor

hershd23 commented Aug 3, 2022

It is ugly, but it has complete information about the test as it just - separates all the parameters.

In the new naming construct, do we want this information in the title or some kind of metadata? Maybe we can also add whether the test was run on the GitHub runner or personal hardware

@gyohuangxin
Copy link
Member Author

@hershd23 Yes, it's just ugly but its information is enough. We can rename this profile name with human readable text, like Istio Soak Test with Fortio, but it‘s also fine if still using -.
@leecalcote What do you think?

@asubedy
Copy link
Member

asubedy commented Aug 4, 2022

Maybe we can also add whether the test was run on the GitHub runner or personal hardware

I guess this would be good to add as a subtext on the card. The performance profile 1,2,3 doesn't look good.

@gyohuangxin
Copy link
Member Author

@asubedy Yes, it's a good idea. Where does the subtext come from? How can we put information here?

@asubedy
Copy link
Member

asubedy commented Aug 4, 2022

@gyohuangxin Right now the subtext is hardcoded.

@hershd23
Copy link
Contributor

hershd23 commented Aug 4, 2022

Sure @asubedy @gyohuangxin let's go with the runner type in the subtext. As far as the main performance test goes, trying to make it a coherent English sentence and - separating stuff doesn't seem different at all to me.

Are we fixated on the Title-Subtitle format @asubedy or can we just specify a UUID type identifier for the test and list the configurations on the card, like service mesh - istio. Test - load test and so on with the datetime of test completion?

@asubedy
Copy link
Member

asubedy commented Aug 4, 2022

@hershd23 I think having a title on the card is necessary. Other details can be listed as you said.

@hershd23
Copy link
Contributor

Hi did we come to any conclusions here?

@gyohuangxin
Copy link
Member Author

Great! As details can be listed in the subcontext, we can list current informations as below:

Istio Load Test with Forito

Service mesh: Istio
Load generator: Fortio
Test configuration: Load test
Date: Aug 10 21:39:33 CST 2022

@gyohuangxin
Copy link
Member Author

@hershd23 @asubedy What do you think?

@asubedy
Copy link
Member

asubedy commented Aug 13, 2022

@gyohuangxin yes this looks good. Just one change, simply date does not explain lots of things, maybe Date updated or date created something that is relevant

@gyohuangxin
Copy link
Member Author

gyohuangxin commented Aug 22, 2022

@asubedy Great, thanks for your suggestion. It looks good.

Istio Load Test with Forito

Service mesh: Istio
Load generator: Fortio
Test configuration: Load test
Date Created: Aug 10 21:39:33 CST 2022
Date Updated: Aug 11 11:29:42 CST 2022

@gyohuangxin
Copy link
Member Author

@hershd23 Can you raise a PR to change the profiles' names?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement Improvement in current feature
Development

No branches or pull requests

4 participants