Skip to content

Commit 2ad728b

Browse files
committed
Adding sign off reminder based on the issue cri-o#59
1 parent 2c8e3e2 commit 2ad728b

File tree

1 file changed

+54
-0
lines changed

1 file changed

+54
-0
lines changed

CONTRIBUTING.md

+54
Original file line numberDiff line numberDiff line change
@@ -11,6 +11,7 @@ Please note that this project is released with a [Contributor Code of Conduct][c
1111
0. Make sure the tests pass on your machine: `script/cibuild`
1212
0. Create a new branch: `git checkout -b my-branch-name`
1313
0. Make your change, add tests, and make sure the tests still pass
14+
1. Sign all your commits
1415
0. Push to your fork and [submit a pull request][pr]
1516
0. Pat your self on the back and wait for your pull request to be reviewed and merged.
1617

@@ -21,6 +22,59 @@ Here are a few things you can do that will increase the likelihood of your pull
2122
- Keep your change as focused as possible. If there are multiple changes you would like to make that are not dependent upon each other, consider submitting them as separate pull requests.
2223
- Write a [good commit message](http://tbaggery.com/2008/04/19/a-note-about-git-commit-messages.html).
2324

25+
### Sign your commits
26+
The sign-off is a line at the end of the explanation for the patch. Your
27+
signature certifies that you wrote the patch or otherwise have the right to pass
28+
it on as an open-source patch. The rules are simple: if you can certify
29+
the below (from [developercertificate.org](http://developercertificate.org/)):
30+
31+
```
32+
Developer Certificate of Origin
33+
Version 1.1
34+
35+
Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
36+
660 York Street, Suite 102,
37+
San Francisco, CA 94110 USA
38+
39+
Everyone is permitted to copy and distribute verbatim copies of this
40+
license document, but changing it is not allowed.
41+
42+
Developer's Certificate of Origin 1.1
43+
44+
By making a contribution to this project, I certify that:
45+
46+
(a) The contribution was created in whole or in part by me and I
47+
have the right to submit it under the open source license
48+
indicated in the file; or
49+
50+
(b) The contribution is based upon previous work that, to the best
51+
of my knowledge, is covered under an appropriate open source
52+
license and I have the right under that license to submit that
53+
work with modifications, whether created in whole or in part
54+
by me, under the same open source license (unless I am
55+
permitted to submit under a different license), as indicated
56+
in the file; or
57+
58+
(c) The contribution was provided directly to me by some other
59+
person who certified (a), (b) or (c) and I have not modified
60+
it.
61+
62+
(d) I understand and agree that this project and the contribution
63+
are public and that a record of the contribution (including all
64+
personal information I submit with it, including my sign-off) is
65+
maintained indefinitely and may be redistributed consistent with
66+
this project or the open source license(s) involved.
67+
```
68+
69+
Then you just add a line to every git commit message:
70+
71+
Signed-off-by: Joe Smith <[email protected]>
72+
73+
Use your real name (sorry, no pseudonyms or anonymous contributions.)
74+
75+
If you set your `user.name` and `user.email` git configs, you can sign your
76+
commit automatically with `git commit -s`.
77+
2478
## Resources
2579

2680
- [Contributing to Open Source on GitHub](https://guides.github.com/activities/contributing-to-open-source/)

0 commit comments

Comments
 (0)