Skip to content

Tree Element Has Wrong Props Type #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
amrabdelshafi97 opened this issue Feb 8, 2021 · 2 comments
Open

Tree Element Has Wrong Props Type #4

amrabdelshafi97 opened this issue Feb 8, 2021 · 2 comments

Comments

@amrabdelshafi97
Copy link

It should be changed from NodeProps to TreeProps

@ldd
Copy link
Owner

ldd commented Mar 14, 2021

yup you are right

 declare function Node<T extends NodeProps>(props: T): JSX.Element;
-  declare function Tree<T extends NodeProps>(props: T): JSX.Element;
+  declare function Tree<T extends TreeProps>(props: T): JSX.Element;

in the distributed index.d.ts, right? tbh, now is a good time as any to update that file. I should've written it in typescript in the first place 😅

@Pangamma
Copy link

Pangamma commented Jun 6, 2023

Really wish this actually worked. Still isn't fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants