Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restart() method missing? #1

Closed
dkotik opened this issue Oct 1, 2019 · 4 comments
Closed

Restart() method missing? #1

dkotik opened this issue Oct 1, 2019 · 4 comments

Comments

@dkotik
Copy link

dkotik commented Oct 1, 2019

Using v0.5.3 - method "Restart" is missing?

@leaanthony
Copy link
Owner

Hi @dkotik. Restart() was removed at the v0.3 release. There was an interesting race condition when using it and as I didn't have time to look at it, I removed it. If you want it back, and have time to debug that (use v0.2) then I'd be more than happy to review a PR 👍

@dkotik
Copy link
Author

dkotik commented Oct 2, 2019

Ok! Thank you for clarification - I just was confused by this paragraph in Readme: https://github.com/leaanthony/spinner#resuse-spinner It needs, perhaps be removed, for now? I am ok without a Restart method.

@leaanthony
Copy link
Owner

leaanthony commented Oct 2, 2019 via email

@leaanthony
Copy link
Owner

At some point, I'll revisit this. Thanks for raising it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants