Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support PRs #171

Open
triallax opened this issue Jul 26, 2021 · 5 comments
Open

Support PRs #171

triallax opened this issue Jul 26, 2021 · 5 comments

Comments

@triallax
Copy link

I took a quick look at the code and it seems like it does, but just to be sure, should this action also work with PRs? If it does, then I believe the default comment should also account for PRs instead of only issues. Also, would there be anything against allowing having a different daysUntilClose for PRs?

I would be willing to open PRs for the above changes.

@native-api
Copy link

Judging by

const issues = await this.octokit.search.issuesAndPullRequests({
q,
sort: 'updated',
order: 'desc',
per_page: 30
})
, it does check both issues and PRs.

@triallax
Copy link
Author

triallax commented Oct 1, 2021

Well, if you go a couple lines up:

const q = `repo:${owner}/${repo} is:issue is:open label:"${responseRequiredLabel}"`

It filters out PRs.

@native-api
Copy link

Then you've answered your own question 🙂

@triallax
Copy link
Author

triallax commented Oct 1, 2021

Haha, fair enough, but I'll keep this open as an issue that requests PR support.

@triallax triallax changed the title Does this work with PRs too? Support PRs Oct 1, 2021
@ryanflorence
Copy link

oh dang, I wanted this mostly for PRs :\

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants