Skip to content

Commit 4096d99

Browse files
committed
Add todo
1 parent 46623a7 commit 4096d99

File tree

1 file changed

+1
-0
lines changed

1 file changed

+1
-0
lines changed

conditioner.hpp

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1568,6 +1568,7 @@ struct PixArtCLIPEmbedder : public Conditioner {
15681568
chunk_hidden_states->ne[0],
15691569
ggml_nelements(hidden_states) / chunk_hidden_states->ne[0]);
15701570
} else {
1571+
// TODO: maybe precompute embeddings for <pad> token and fill with that instead? (proper uncond)
15711572
hidden_states = ggml_new_tensor_2d(work_ctx, GGML_TYPE_F32, 4096, chunk_len);
15721573
ggml_set_f32(hidden_states, 0.f);
15731574
t5_attn_mask = ggml_new_tensor_1d(work_ctx, GGML_TYPE_F32, chunk_len);

0 commit comments

Comments
 (0)