Skip to content

Commit 246c113

Browse files
committed
add comments && update annotations
1 parent 9d404fe commit 246c113

File tree

9 files changed

+32
-6
lines changed

9 files changed

+32
-6
lines changed

src/Contracts/Interactions/UserLogin.php

Lines changed: 16 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,24 +15,32 @@
1515
interface UserLogin
1616
{
1717
/**
18+
* Retrive user from credential in request
19+
*
1820
* @param Request $request
19-
* @return UserModel
21+
* @return UserModel|null
2022
*/
2123
public function login(Request $request);
2224

2325
/**
26+
* Get current logged in user
27+
*
2428
* @param Request $request
2529
* @return UserModel|null
2630
*/
2731
public function getCurrentUser(Request $request);
2832

2933
/**
34+
* Show failed message when authenticate failed
35+
*
3036
* @param Request $request
3137
* @return Response
3238
*/
3339
public function showAuthenticateFailed(Request $request);
3440

3541
/**
42+
* Show login page with warning message
43+
*
3644
* @param Request $request
3745
* @param string $jumpUrl
3846
* @param string $service
@@ -41,25 +49,32 @@ public function showAuthenticateFailed(Request $request);
4149
public function showLoginWarnPage(Request $request, $jumpUrl, $service);
4250

4351
/**
52+
* Show login page
53+
*
4454
* @param Request $request
4555
* @param array $errors
4656
* @return Response
4757
*/
4858
public function showLoginPage(Request $request, array $errors = []);
4959

5060
/**
61+
* Redirect to home page
62+
*
5163
* @param array $errors
5264
* @return Response
5365
*/
5466
public function redirectToHome(array $errors = []);
5567

5668
/**
69+
* Execute logout logic (clear session / cookie etc)
70+
*
5771
* @param Request $request
5872
* @return void
5973
*/
6074
public function logout(Request $request);
6175

6276
/**
77+
*
6378
* @param Request $request
6479
* @return Response
6580
*/

src/Contracts/Models/UserModel.php

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -13,11 +13,15 @@
1313
interface UserModel
1414
{
1515
/**
16+
* Get user's name (should be unique in whole cas system)
17+
*
1618
* @return string
1719
*/
1820
public function getName();
1921

2022
/**
23+
* Get user's attributes
24+
*
2125
* @return array
2226
*/
2327
public function getCASAttributes();

src/Contracts/Responses/ProxyFailureResponse.php

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,6 @@
88

99
namespace Leo108\CAS\Contracts\Responses;
1010

11-
1211
interface ProxyFailureResponse extends BaseResponse
1312
{
1413
/**

src/Contracts/TicketLocker.php

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,6 @@
88

99
namespace Leo108\CAS\Contracts;
1010

11-
1211
interface TicketLocker
1312
{
1413
/**

src/Models/PGTicket.php

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -25,6 +25,7 @@
2525
* @property Carbon $created_at
2626
* @property Carbon $expire_at
2727
* @property UserModel $user
28+
* @property Service $service
2829
*/
2930
class PGTicket extends Model
3031
{

src/Models/ServiceHost.php

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -10,6 +10,13 @@
1010

1111
use Illuminate\Database\Eloquent\Model;
1212

13+
/**
14+
* Class ServiceHost
15+
* @package Leo108\CAS\Models
16+
*
17+
* @property integer $service_id
18+
* @property Service $service
19+
*/
1320
class ServiceHost extends Model
1421
{
1522
protected $table = 'cas_service_hosts';

src/Models/Ticket.php

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -25,6 +25,7 @@
2525
* @property Carbon $created_at
2626
* @property Carbon $expire_at
2727
* @property UserModel $user
28+
* @property Service $service
2829
*/
2930
class Ticket extends Model
3031
{

src/Repositories/TicketRepository.php

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -49,7 +49,7 @@ public function __construct(Ticket $ticket, ServiceRepository $serviceRepository
4949
* @param string $serviceUrl
5050
* @param array $proxies
5151
* @throws CasException
52-
* @return \Leo108\CAS\Models\Ticket
52+
* @return Ticket
5353
*/
5454
public function applyTicket(UserModel $user, $serviceUrl, $proxies = [])
5555
{
@@ -117,4 +117,4 @@ function ($ticket) {
117117
10
118118
);
119119
}
120-
}
120+
}

src/Responses/BaseXmlResponse.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -93,4 +93,4 @@ public function toResponse()
9393

9494
return new Response($content, 200, ['Content-Type' => 'application/xml']);
9595
}
96-
}
96+
}

0 commit comments

Comments
 (0)