Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IPageService, INavigationAware, INavigableView not found (4.0.2-rc) #1278

Open
nandaccio opened this issue Nov 17, 2024 · 6 comments
Open

IPageService, INavigationAware, INavigableView not found (4.0.2-rc) #1278

nandaccio opened this issue Nov 17, 2024 · 6 comments
Labels
bug Something isn't working

Comments

@nandaccio
Copy link

nandaccio commented Nov 17, 2024

Describe the bug

Version 4.0.2-rc breaks existing code based on the WPUI template. I looked for information about breaking changes on https://github.com/lepoco/wpfui/releases and the main page of the repo, I also installed:

<PackageReference Include="WPF-UI.Abstractions" Version="4.0.0-rc.2" />
<PackageReference Include="WPF-UI.DependencyInjection" Version="4.0.0-rc.2" />

But I can no longer compile the project because of several errors:

  • IPageService is not available
  • INavigationAware is not available
  • INavigableView is not available
  • NavigationView does not contain a definition of SetPageService
  • MainWindow does not implement INavigationWindow.SetPageService
    etc

To Reproduce

Update a simple project based on the official templates for 3.x to use 4.x (including WPF-UI.Abstractions)

Workaround:
Revert to

  <ItemGroup>
    <PackageReference Include="WPF-UI" Version="3.0.5" />
    <PackageReference Include="Microsoft.Extensions.Hosting" Version="9.0.0" />
    <PackageReference Include="CommunityToolkit.Mvvm" Version="8.4.0-preview2" />
  </ItemGroup>

Expected behavior

Breaking changes should be documented,

Screenshots

No response

OS version

Windows 11

.NET version

.NET 8

WPF-UI NuGet version

Additional context

No response

@nandaccio nandaccio added the bug Something isn't working label Nov 17, 2024
@khimoc97
Copy link

Me also got the issue when upgrade from 3.0.5 to 4.0.0-rc.2
image

@symonxdd
Copy link

symonxdd commented Feb 5, 2025

Wow! How can such a groundbreaking change not be documented in the release notes... my app literally doesn't compile anymore with loads of compile-time errors smh

@nabeelio
Copy link

nabeelio commented Feb 8, 2025

Same, on the release version. The docs also still show IPageService still being used

@nabeelio
Copy link

nabeelio commented Feb 8, 2025

I guess it's called INavigationViewPageProvider now?

@nabeelio
Copy link

nabeelio commented Feb 8, 2025

Yep,

  • IPageService -> INavigationViewPageProvider - reimplement the interface
- NavigationControl.SetPageService(_pageService);
- +NavigationControl.SetPageProviderService(_pageService);

@BorisovskiP
Copy link

I also get this issue in the 4.0.0 release. Have to revert to version 3.0.5 to have my app working again. @pomianowski is there any documentation on what changed here?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

5 participants