Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ContentDialog missing radius on bottom corners in Light mode when IsFooterVisible=False #1309

Open
oklahsam opened this issue Jan 8, 2025 · 1 comment
Labels
bug Something isn't working

Comments

@oklahsam
Copy link

oklahsam commented Jan 8, 2025

Describe the bug

When showing a content dialog with IsFooterVisible=False, the bottom corners are missing the radius (not rounded) in the Light mode theme.

To Reproduce

Create a content dialog, either in XAML or using the ContentDialogService, and set IsFooterVisible=False. Then switch between Light and Dark mode to see the difference.

Expected behavior

The bottom corners of the ContentDialog should be rounded in Light mode like they are in Dark mode.

Screenshots

Light Mode:
image

Dark Mode:
image

OS version

Windows 11 Pro (23H2, build 22531.4602)

.NET version

.NET 8

WPF-UI NuGet version

WPF-UI 3.0.5

Additional context

No response

@oklahsam oklahsam added the bug Something isn't working label Jan 8, 2025
@oklahsam
Copy link
Author

I've discovered that the issue comes down to the LayerFillColorAlt color applied to the ContentDialogTopOverlay brush used on the Border element of the ContentDialog control that uses the DialogOverlayCornerRadius.
The color in Dark mode is set to #0DFFFFFF which is White with an opacity of 5%, while in Light mode it is #FFFFFFFF which is White with an opacity of 100%.
It's a little difficult to see, but if you zoom in on the corner in dark mode, you can see the faint, transparent, un-radiused border.
image

Not sure what the best solution for this is. A style trigger to change the corner radius depending on the setting of IsFooterVisible seems reasonable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant