Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support clean-css v4 #18

Closed
ngyikp opened this issue Feb 1, 2017 · 4 comments · Fixed by #37
Closed

Support clean-css v4 #18

ngyikp opened this issue Feb 1, 2017 · 4 comments · Fixed by #37

Comments

@ngyikp
Copy link

ngyikp commented Feb 1, 2017

https://github.com/jakubpawlowicz/clean-css/blob/master/README.md#important-40-breaking-changes

@XhmikosR
Copy link
Contributor

@lukeapage: how do you want to handle the upgrade? IMO we should remove advanced etc and keep clean-css's O1 defaults.

@rjgotten
Copy link

@XhmikosR
Just chiming in here: imho, ideally you'll want to detect the version in use for CleanCSS and switch on that, continuing support for the old API as people may be stuck using the 3.x branch for some reason or other.

While afaict CleanCSS doesn't have a version member on its exported object, you can still grab it from the package.json file. Very easy to do, actually:

var cleanCssVersion = require("clean-css/package.json").version;

For the CLI options in v4, you can probably directly copy a large part of the argument parsing logic from the clean-css-cli package as well.

@XhmikosR
Copy link
Contributor

Well, all this is nice and all, but 1) this repo has no tests and 2) I don't want to make so many changes myself. So we need someone to submit a working PR for the current clean-css version and if/when there is a bump we decide how to proceed with old versions.

@joeyparrish
Copy link

Upgrading would also fix #26.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants