-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support clean-css v4 #18
Comments
@lukeapage: how do you want to handle the upgrade? IMO we should remove advanced etc and keep clean-css's O1 defaults. |
@XhmikosR While afaict CleanCSS doesn't have a var cleanCssVersion = require("clean-css/package.json").version; For the CLI options in v4, you can probably directly copy a large part of the argument parsing logic from the |
Well, all this is nice and all, but 1) this repo has no tests and 2) I don't want to make so many changes myself. So we need someone to submit a working PR for the current clean-css version and if/when there is a bump we decide how to proceed with old versions. |
Upgrading would also fix #26. |
https://github.com/jakubpawlowicz/clean-css/blob/master/README.md#important-40-breaking-changes
The text was updated successfully, but these errors were encountered: