Upgrade clean css and add basic tests #37
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
|
Hey @matthew-dean, do you need anything else from me? Is this pr ok? |
|
@derTobsch I guess this plugin has no tests? 🤔 |
Yep :) Not even one. |
|
@derTobsch If you feel pretty confident about this, I think we can merge it |
go for it. Otherwise we will fix it |
|
@matthew-dean is there anything else I can do? |
|
ping :) |
|
@matthew-dean, how does it look? |
|
Hey @matthew-dean, its me again :) I added the basic tests from #27 (#30) and also added a github workflow to run the tests. You need to enable GitHub Actions for this repo to see the results. |
derTobsch
changed the title
|
Yeah and thanks @matthew-dean. I think we can now close #30 and #33 |
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
clean-cssto5.3.3constandletinstead ofvarIt should still work, but please check again
❯ lessc file.less --clean-css="--s1 --advanced --compatibility=ie8" h2{color:coral}h3{color:purple}%contains #30
closes #36
closes #29
closes #27
closes #26
closes #18