Skip to content

Commit 22d8abb

Browse files
committed
allowed array parameter in addVersion method
1 parent d3aed49 commit 22d8abb

File tree

4 files changed

+15
-7
lines changed

4 files changed

+15
-7
lines changed

README.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -304,8 +304,8 @@ try {
304304
->setPriorityName("Critical")
305305
->setIssueType("Bug")
306306
->setDescription("Full description for issue")
307-
->addVersion("1.0.1")
308-
->addVersion("1.0.3");
307+
->addVersion(["1.0.1", "1.0.3"])
308+
->addComponents(['Component-1', 'Component-2']);
309309

310310
$issueService = new IssueService();
311311

src/Issue/IssueField.php

Lines changed: 7 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -161,9 +161,13 @@ public function addVersion($name)
161161
$this->versions = array();
162162
}
163163

164-
$v = new Version();
165-
$v->name = $name;
166-
array_push($this->versions, $v);
164+
if (is_string($name)){
165+
array_push($this->versions, new Version($name));
166+
} else if (is_array($name)) {
167+
foreach($name as $v) {
168+
array_push($this->versions, new Version($v));
169+
}
170+
}
167171

168172
return $this;
169173
}

src/Issue/Version.php

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -25,6 +25,11 @@ class Version implements \JsonSerializable
2525
/* @var DateTime */
2626
public $releaseDate;
2727

28+
public function __construct($name)
29+
{
30+
$this->name = $name;
31+
}
32+
2833
public function jsonSerialize()
2934
{
3035
return array_filter(get_object_vars($this));

tests/IssueTest.php

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -36,8 +36,7 @@ public function testCreateIssue()
3636
->setPriorityName('Critical')
3737
->setIssueType('Bug')
3838
->setDescription('Full description for issue')
39-
->addVersion('1.0.1')
40-
->addVersion('1.0.3')
39+
->addVersion(['1.0.1', '1.0.3'])
4140
->addComponents(['Component-1', 'Component-2'])
4241
;
4342

0 commit comments

Comments
 (0)