Add is_array check in IssueService::addAttachments

say1hello · web-flow · commit 7d58d6881ae3 · 2017-01-20T12:25:30.000+03:00
Add is_array check in \JiraRestApi\Issue\IssueService::addAttachments method
diff --git a/src/Issue/IssueService.php b/src/Issue/IssueService.php
@@ -133,9 +133,10 @@ public function addAttachments($issueIdOrKey, $filePathArray)
 
         $resArr = array();
         foreach ($results as $ret) {
+            $ret = json_decode($ret);
             if (is_array($ret)) {
                 array_push($resArr, $this->json_mapper->mapArray(
-                   json_decode($ret), new \ArrayObject(), '\JiraRestApi\Issue\Attachment'
+                    $ret, new \ArrayObject(), '\JiraRestApi\Issue\Attachment'
                     )
                 );
             }

Original file line number	Diff line number	Diff line change
`@@ -133,9 +133,10 @@ public function addAttachments($issueIdOrKey, $filePathArray)`
`133`	`133`
`134`	`134`	`$resArr = array();`
`135`	`135`	`foreach ($results as $ret) {`
	`136`	`+ $ret = json_decode($ret);`
`136`	`137`	`if (is_array($ret)) {`
`137`	`138`	`array_push($resArr, $this->json_mapper->mapArray(`
`138`		`- json_decode($ret), new \ArrayObject(), '\JiraRestApi\Issue\Attachment'`
	`139`	`+ $ret, new \ArrayObject(), '\JiraRestApi\Issue\Attachment'`
`139`	`140`	`)`
`140`	`141`	`);`
`141`	`142`	`}`