Add unit tests

Author: aarongable

wfe2/wfe.go

@@ -682,7 +682,7 @@ func (wfe *WebFrontEndImpl) contactsToEmails(contacts []string) ([]string, error
 
 		err = policy.ValidEmail(parsed.Opaque)
 		if err != nil {
-			continue
+			return nil, err
 		}
 
 		emails = append(emails, parsed.Opaque)

wfe2/wfe_test.go

@@ -429,6 +429,7 @@ func setupWFE(t *testing.T) (WebFrontEndImpl, clock.FakeClock, requestSigner) {
 		blog.NewMock(),
 		10*time.Second,
 		10*time.Second,
+		2,
 		&MockRegistrationAuthority{clk: fc},
 		mockSA,
 		nil,
@@ -1647,6 +1648,124 @@ func TestNewAccountNoID(t *testing.T) {
 	}`)
 }
 
+func TestContactsToEmails(t *testing.T) {
+	t.Parallel()
+	wfe, _, _ := setupWFE(t)
+
+	for _, tc := range []struct {
+		name     string
+		contacts []string
+		want     []string
+		wantErr  string
+	}{
+		{
+			name:     "no contacts",
+			contacts: []string{},
+			want:     []string{},
+		},
+		{
+			name:     "happy path",
+			contacts: []string{"mailto:[email protected]", "mailto:[email protected]"},
+			want:     []string{"[email protected]", "[email protected]"},
+		},
+		{
+			name:     "empty url",
+			contacts: []string{""},
+			wantErr:  "empty contact",
+		},
+		{
+			name:     "too many contacts",
+			contacts: []string{"mailto:[email protected]", "mailto:[email protected]", "mailto:[email protected]"},
+			wantErr:  "too many contacts",
+		},
+		{
+			name:     "unknown scheme",
+			contacts: []string{"ansible:earth.sol.milkyway.laniakea/letsencrypt"},
+			wantErr:  "contact scheme",
+		},
+		{
+			name:     "malformed email",
+			contacts: []string{"mailto:admin.com"},
+			wantErr:  "unable to parse email address",
+		},
+		{
+			name:     "non-ascii email",
+			contacts: []string{"mailto:señ[email protected]"},
+			wantErr:  "contains non-ASCII characters",
+		},
+		{
+			name:     "unarseable email",
+			contacts: []string{"mailto:[email protected], [email protected]"},
+			wantErr:  "unable to parse email address",
+		},
+		{
+			name:     "forbidden example domain",
+			contacts: []string{"mailto:[email protected]"},
+			wantErr:  "forbidden",
+		},
+		{
+			name:     "forbidden non-public domain",
+			contacts: []string{"mailto:admin@localhost"},
+			wantErr:  "needs at least one dot",
+		},
+		{
+			name:     "forbidden non-iana domain",
+			contacts: []string{"mailto:[email protected]"},
+			wantErr:  "does not end with a valid public suffix",
+		},
+		{
+			name:     "forbidden ip domain",
+			contacts: []string{"mailto:[email protected]"},
+			wantErr:  "value is an IP address",
+		},
+		{
+			name:     "forbidden bracketed ip domain",
+			contacts: []string{"mailto:admin@[1.2.3.4]"},
+			wantErr:  "contains an invalid character",
+		},
+		{
+			name:     "query parameter",
+			contacts: []string{"mailto:[email protected]?no-reminder-emails"},
+			wantErr:  "contains a question mark",
+		},
+		{
+			name:     "empty query parameter",
+			contacts: []string{"mailto:[email protected]?"},
+			wantErr:  "contains a question mark",
+		},
+		{
+			name:     "fragment url",
+			contacts: []string{"mailto:[email protected]#optional"},
+			wantErr:  "contains a '#'",
+		},
+		{
+			name:     "empty frament url",
+			contacts: []string{"mailto:[email protected]#"},
+			wantErr:  "contains a '#'",
+		},
+	} {
+		t.Run(tc.name, func(t *testing.T) {
+			t.Parallel()
+			got, err := wfe.contactsToEmails(tc.contacts)
+			if tc.wantErr != "" {
+				if err == nil {
+					t.Fatalf("contactsToEmails(%#v) = nil, but want %q", tc.contacts, tc.wantErr)
+				}
+				if !strings.Contains(err.Error(), tc.wantErr) {
+					t.Errorf("contactsToEmails(%#v) = %q, but want %q", tc.contacts, err.Error(), tc.wantErr)
+				}
+			} else {
+				if err != nil {
+					t.Fatalf("contactsToEmails(%#v) = %q, but want %#v", tc.contacts, err.Error(), tc.want)
+				}
+				if !slices.Equal(got, tc.want) {
+					t.Errorf("contactsToEmails(%#v) = %#v, but want %#v", tc.contacts, got, tc.want)
+				}
+			}
+		})
+	}
+}
+
 func TestGetAuthorizationHandler(t *testing.T) {
 	wfe, _, signer := setupWFE(t)
 
@@ -4189,7 +4308,7 @@ func TestNewAccountCreatesContacts(t *testing.T) {
 		{
 			name:     "One valid email, one invalid email",
 			contacts: []string{"mailto:[email protected]", "mailto:lol@%mail.com"},
-			expected: []string{"[email protected]"},
+			expected: []string{},
 		},
 		{
 			name:     "Valid email with non-email prefix",