Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More diffthis trailing newline staging issues #1205

Closed
joshuarubin opened this issue Feb 5, 2025 · 2 comments
Closed

More diffthis trailing newline staging issues #1205

joshuarubin opened this issue Feb 5, 2025 · 2 comments

Comments

@joshuarubin
Copy link
Contributor

Since #1175 landed, now I'm getting the opposite issue that had been reported in #1145. Before it landed, things were working fine. Now, my staged files are getting trailing newlines stripped so there's always a diff whenever writing a staging file with diffthis.

My hunch with this is that there may be different initial values for eol and fixeol. I have both eol and fixeol enabled (which is the default). If I manually :set eol in the staging buffer in diffthis, then I can write the buffer with the trailing newline properly appended and no diff between staging and the local workspace.

@lewis6991
Copy link
Owner

Need to reproduce in order to look into it. Please use the issue template.

@joshuarubin
Copy link
Contributor Author

So sorry. I had a remediation in an autocmd that was setting noeol and nofixeol in gitsigns buffers. Things do in fact work fine now, no remediation necessary anymore. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants