Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

when used as mouse_provider, Diagnostics provider shows diagnostics from cursor position not mouse position #73

Open
apaleslimghost opened this issue Jul 12, 2024 · 1 comment · May be fixed by #80
Open

when used as mouse_provider, Diagnostics provider shows diagnostics from cursor position not mouse position #73

apaleslimghost opened this issue Jul 12, 2024 · 1 comment · May be fixed by #80

Comments

@apaleslimghost
Copy link

Screenshot 2024-07-12 at 10 45 56

(couldn't get cursor showing in the screenshot, it's hovering over isPlainObject)

looks like filter_diagnostics is explicitly calling nvim_win_get_cursor instead of using the passed-in opts.pos. will raise a PR when i get chance to try fixing it in a custom provider
@PgBiel
Copy link

PgBiel commented Feb 8, 2025 •
edited
Loading

Also here:

hover.nvim/lua/hover/actions.lua

Line 181 in 140c4d0

popts.pos = popts.pos or api.nvim_win_get_cursor(0)

Edit: Actually, that one is used specifically by keybinds, so it is correct. However, it was also wrong for fold preview; I've submitted a PR (#80).

@PgBiel PgBiel linked a pull request Feb 8, 2025 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Use mouse position for diagnostic and fold preview PgBiel/hover.nvim
2 participants
@apaleslimghost @PgBiel