Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MSVC: options ecdh/recovery not configured on exe builds. #6

Open
evoskuil opened this issue Nov 19, 2019 · 3 comments
Open

MSVC: options ecdh/recovery not configured on exe builds. #6

evoskuil opened this issue Nov 19, 2019 · 3 comments
Labels
build

Comments

@evoskuil
Copy link
Member 

1>------ Rebuild All started: Project: secp256k1, Configuration: ReleaseLIB x64 ------
1>ConfigurationType : StaticLibrary
1>Configuration     : ReleaseLIB
1>PlatformToolset   : v141
1>TargetPath        : secp256k1\builds\msvc\vs2017\secp256k1\..\..\..\..\bin\x64\Release\v141\static\secp256k1.lib
1>Option-gmp          :
1>Option-assembly     :
1>Option-endomorphism : true
1>Option-config       :
1>Option-field64      :
1>Option-scalar64     :
1>Option-ecdh         : true
1>Option-recovery     : true
1>Option-schnorrsig   : true
1>lax_der_parsing.c
1>lax_der_privatekey_parsing.c
1>secp256k1.c
1>secp256k1\src\ecmult_impl.h(1028): warning C4334: '<<': result of 32-bit shift implicitly converted to 64 bits (was 64-bit shift intended?) (compiling source file ..\..\..\..\src\secp256k1.c)
1>secp256k1.vcxproj -> secp256k1\builds\msvc\vs2017\secp256k1\..\..\..\..\bin\x64\Release\v141\static\secp256k1.lib
1>Done building project "secp256k1.vcxproj".
2>------ Rebuild All started: Project: secp256k1_bench, Configuration: ReleaseSEXE x64 ------
3>------ Rebuild All started: Project: secp256k1_tests, Configuration: ReleaseSEXE x64 ------
2>ConfigurationType : Application
2>Configuration     : ReleaseSEXE
2>PlatformToolset   : v141
2>TargetPath        : secp256k1\builds\msvc\vs2017\secp256k1_bench\..\..\..\..\bin\x64\Release\v141\static\secp256k1_bench.exe
2>Option-gmp          :
2>Option-assembly     :
2>Option-endomorphism : true
2>Option-config       :
2>Option-field64      :
2>Option-scalar64     :
2>Option-ecdh         :
2>Option-recovery     :
2>Linkage-secp256k1   : static
2>bench_schnorrsig.c
2>..\..\..\..\src\bench_schnorrsig.c(70): warning C4090: 'function': different 'const' qualifiers
2>..\..\..\..\src\bench_schnorrsig.c(121): warning C4090: 'function': different 'const' qualifiers
2>..\..\..\..\src\bench_schnorrsig.c(122): warning C4090: 'function': different 'const' qualifiers
2>..\..\..\..\src\bench_schnorrsig.c(123): warning C4090: 'function': different 'const' qualifiers
3>ConfigurationType : Application
3>Configuration     : ReleaseSEXE
3>PlatformToolset   : v141
3>TargetPath        : secp256k1\builds\msvc\vs2017\secp256k1_tests\..\..\..\..\bin\x64\Release\v141\static\secp256k1_tests.exe
3>Option-gmp          :
3>Option-assembly     :
3>Option-endomorphism : true
3>Option-config       :
3>Option-field64      :
3>Option-scalar64     :
3>Option-testssl      :
3>Option-ecdh         :
3>Option-recovery     :
3>Linkage-secp256k1   : static
3>tests.c
3>secp256k1\src\ecmult_impl.h(1028): warning C4334: '<<': result of 32-bit shift implicitly converted to 64 bits (was 64-bit shift intended?)
2>secp256k1_bench.vcxproj -> secp256k1\builds\msvc\vs2017\secp256k1_bench\..\..\..\..\bin\x64\Release\v141\static\secp256k1_bench.exe
2>Done building project "secp256k1_bench.vcxproj".
3>ConfigurationType : StaticLibrary
3>Configuration     : ReleaseLIB
3>PlatformToolset   : v141
3>TargetPath        : secp256k1\builds\msvc\vs2017\secp256k1\..\..\..\..\bin\x64\Release\v141\static\secp256k1.lib
3>Option-gmp          :
3>Option-assembly     :
3>Option-endomorphism : true
3>Option-config       :
3>Option-field64      :
3>Option-scalar64     :
3>Option-ecdh         : true
3>Option-recovery     : true
3>Option-schnorrsig   : true
@evoskuil evoskuil added the build label Nov 19, 2019
@evoskuil evoskuil changed the title MSVC: options ecdh and recovery not configured on executable builds. MSVC: options ecdh/recovery not configured on exe builds. Nov 19, 2019
@npodonnell
Copy link

npodonnell commented Nov 25, 2019 •
edited
Loading

Same on *nix. If it's any help, this fixed it for me:

./configure  --enable-module-recovery --enable-module-ecdh

@evoskuil
Copy link
Member Author

Yes, that’s a required setting.

@evoskuil evoskuil reopened this Nov 25, 2019
@evoskuil
Copy link
Member Author

This issue pertains to something else.

evoskuil pushed a commit that referenced this issue Mar 9, 2025
@real-or-random
Merge bitcoin-core#1582: cmake, test: Add secp256k1_ prefix to test…

Unverified

The email in this signature doesn’t match the committer email.
GPG key ID: 8C461CCD293F6011
Learn about vigilant mode
9a8db52 
… names

87384f5 cmake, test: Add `secp256k1_` prefix to test names (Hennadii Stepanov)

Pull request description:

  This PR improves regex matching options when using `ctest` in downstream projects, such as Bitcoin Core.

  For instance, a downstream project users can filter their tests like that:
  ```
  ctest --tests-regex "secp256k1"
  ```
  or
  ```
  ctest --exclude-regex "secp256k1"
  ```

  A `ctest` log with this PR:
  ```
  $ ctest --test-dir build -j 16
  Internal ctest changing into directory: /home/hebasto/git/secp256k1/secp256k1/build
  Test project /home/hebasto/git/secp256k1/secp256k1/build
      Start 1: secp256k1_noverify_tests
      Start 2: secp256k1_tests
      Start 3: secp256k1_exhaustive_tests
      Start 4: secp256k1_ecdsa_example
      Start 5: secp256k1_ecdh_example
      Start 6: secp256k1_schnorr_example
      Start 7: secp256k1_ellswift_example
      Start 8: secp256k1_musig_example
  1/8 Test #4: secp256k1_ecdsa_example ..........   Passed    0.00 sec
  2/8 Test #5: secp256k1_ecdh_example ...........   Passed    0.00 sec
  3/8 Test #6: secp256k1_schnorr_example ........   Passed    0.00 sec
  4/8 Test #7: secp256k1_ellswift_example .......   Passed    0.00 sec
  5/8 Test #8: secp256k1_musig_example ..........   Passed    0.00 sec
  6/8 Test #3: secp256k1_exhaustive_tests .......   Passed    6.19 sec
  7/8 Test #1: secp256k1_noverify_tests .........   Passed   38.83 sec
  8/8 Test #2: secp256k1_tests ..................   Passed   91.66 sec

  100% tests passed, 0 tests failed out of 8

  Total Test time (real) =  91.67 sec
  ```

ACKs for top commit:
  theuni:
    utACK 87384f5
  real-or-random:
    utACK 87384f5

Tree-SHA512: d8e46558cf58c9c660544b7bdfed24c991eb3e120b6511aa3968f509190130e498749a3c4dbabc87a7f22f0aa0056c6bcd3fc6c44f5eb131588945d593546840
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
build
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@evoskuil @npodonnell