Merge pull request #2099 from enriqueraso/bug/Repositoy.Worktrees.Add_creates_an_empty_folder_for_the_worktree

Fix empty folder issue in Repositoy.Worktrees.Add

Author: bording

LibGit2Sharp.Tests/WorktreeFixture.cs

@@ -1,10 +1,8 @@
-using LibGit2Sharp.Tests.TestHelpers;
-using System;
+using System;
 using System.Collections.Generic;
 using System.IO;
 using System.Linq;
-using System.Text;
-using System.Threading.Tasks;
+using LibGit2Sharp.Tests.TestHelpers;
 using Xunit;
 
 namespace LibGit2Sharp.Tests
@@ -238,7 +236,7 @@ public void CanForcePruneLockedWorktree()
         }
 
         [Fact]
-        public void CanAddWorktree()
+        public void CanAddWorktree_WithUncommitedChanges()
         {
             var repoPath = SandboxWorktreeTestRepo();
             using (var repo = new Repository(repoPath))
@@ -252,11 +250,54 @@ public void CanAddWorktree()
                 Assert.False(worktree.IsLocked);
 
                 Assert.Equal(3, repo.Worktrees.Count());
+
+                // Check that branch contains same number of files and folders
+                Assert.True(repo.RetrieveStatus().IsDirty);
+                var filesInMain = GetFilesOfRepo(repoPath);
+                var filesInBranch = GetFilesOfRepo(path);
+                Assert.NotEqual(filesInMain, filesInBranch);
+
+                repo.Reset(ResetMode.Hard);
+                repo.RemoveUntrackedFiles();
+
+                Assert.False(repo.RetrieveStatus().IsDirty);
+                filesInMain = GetFilesOfRepo(repoPath);
+                filesInBranch = GetFilesOfRepo(path);
+                Assert.Equal(filesInMain, filesInBranch);
             }
         }
 
         [Fact]
-        public void CanAddLockedWorktree()
+        public void CanAddWorktree_WithCommitedChanges()
+        {
+            var repoPath = SandboxWorktreeTestRepo();
+            using (var repo = new Repository(repoPath))
+            {
+                // stage all changes
+                Commands.Stage(repo, "*");
+                repo.Commit("Apply all changes", Constants.Signature, Constants.Signature);
+
+                Assert.Equal(2, repo.Worktrees.Count());
+
+                var name = "blah";
+                var path = Path.Combine(repo.Info.WorkingDirectory, "..", "worktrees", name);
+                var worktree = repo.Worktrees.Add(name, path, false);
+                Assert.Equal(name, worktree.Name);
+                Assert.False(worktree.IsLocked);
+
+                Assert.Equal(3, repo.Worktrees.Count());
+
+                // Check that branch contains same number of files and folders
+                Assert.False(repo.RetrieveStatus().IsDirty);
+                var filesInMain = GetFilesOfRepo(repoPath);
+                var filesInBranch = GetFilesOfRepo(path);
+
+                Assert.Equal(filesInMain, filesInBranch);
+            }
+        }
+
+        [Fact]
+        public void CanAddLockedWorktree_WithUncommitedChanges()
         {
             var repoPath = SandboxWorktreeTestRepo();
             using (var repo = new Repository(repoPath))
@@ -270,6 +311,48 @@ public void CanAddLockedWorktree()
                 Assert.True(worktree.IsLocked);
 
                 Assert.Equal(3, repo.Worktrees.Count());
+
+                // Check that branch contains same number of files and folders
+                Assert.True(repo.RetrieveStatus().IsDirty);
+                var filesInMain = GetFilesOfRepo(repoPath);
+                var filesInBranch = GetFilesOfRepo(path);
+                Assert.NotEqual(filesInMain, filesInBranch);
+
+                repo.Reset(ResetMode.Hard);
+                repo.RemoveUntrackedFiles();
+
+                Assert.False(repo.RetrieveStatus().IsDirty);
+                filesInMain = GetFilesOfRepo(repoPath);
+                filesInBranch = GetFilesOfRepo(path);
+                Assert.Equal(filesInMain, filesInBranch);
+            }
+        }
+
+        [Fact]
+        public void CanAddLockedWorktree_WithCommitedChanges()
+        {
+            var repoPath = SandboxWorktreeTestRepo();
+            using (var repo = new Repository(repoPath))
+            {
+                // stage all changes
+                Commands.Stage(repo, "*");
+                repo.Commit("Apply all changes", Constants.Signature, Constants.Signature);
+
+                Assert.Equal(2, repo.Worktrees.Count());
+
+                var name = "blah";
+                var path = Path.Combine(repo.Info.WorkingDirectory, "..", "worktrees", name);
+                var worktree = repo.Worktrees.Add(name, path, true);
+                Assert.Equal(name, worktree.Name);
+                Assert.True(worktree.IsLocked);
+
+                Assert.Equal(3, repo.Worktrees.Count());
+
+                // Check that branch contains same number of files and folders
+                Assert.False(repo.RetrieveStatus().IsDirty);
+                var filesInMain = GetFilesOfRepo(repoPath);
+                var filesInBranch = GetFilesOfRepo(path);
+                Assert.Equal(filesInMain, filesInBranch);
             }
         }
 
@@ -292,7 +375,21 @@ public void CanAddWorktreeForCommittish()
                     Assert.Equal(committish, repository.Head.FriendlyName);
                 }
                 Assert.Equal(3, repo.Worktrees.Count());
+
+                // Check that branch contains same number of files and folders
+                var filesInCommittish = new string[] { "numbers.txt", "super-file.txt" };
+                var filesInBranch = GetFilesOfRepo(path);
+                Assert.Equal(filesInCommittish, filesInBranch);
             }
         }
+
+        private static IEnumerable<string> GetFilesOfRepo(string repoPath)
+        {
+            return Directory.GetFiles(repoPath, "*", SearchOption.AllDirectories)
+                .Where(fileName => !fileName.StartsWith(Path.Combine(repoPath, ".git")))
+                .Select(fileName => fileName.Replace($"{repoPath}{Path.DirectorySeparatorChar}", ""))
+                .OrderBy(fileName => fileName)
+                .ToList();
+        }
     }
 }

LibGit2Sharp/Core/GitWorktree.cs

@@ -38,7 +38,11 @@ internal class git_worktree_add_options
 
         public IntPtr @ref = IntPtr.Zero;
 
-        public GitCheckoutOpts checkoutOpts = new GitCheckoutOpts { version = 1 };
+        public GitCheckoutOpts checkoutOpts = new GitCheckoutOpts
+        {
+            version = 1,
+            checkout_strategy = CheckoutStrategy.GIT_CHECKOUT_SAFE
+        };
     }
 
     [StructLayout(LayoutKind.Sequential)]

LibGit2Sharp/WorktreeCollection.cs

@@ -46,13 +46,12 @@ public virtual Worktree this[string name]
         }
 
         /// <summary>
-        ///
+        /// Creates a worktree.
         /// </summary>
-        /// <param name="committishOrBranchSpec"></param>
-        /// <param name="name"></param>
-        /// <param name="path"></param>
+        /// <param name="committishOrBranchSpec">The committish to checkout into the new worktree.</param>
+        /// <param name="name">Name of the worktree.</param>
+        /// <param name="path">Location of the worktree.</param>
         /// <param name="isLocked"></param>
-        /// <returns></returns>
         public virtual Worktree Add(string committishOrBranchSpec, string name, string path, bool isLocked)
         {
             if (string.Equals(committishOrBranchSpec, name))
@@ -61,7 +60,7 @@ public virtual Worktree Add(string committishOrBranchSpec, string name, string p
                 return null;
             }
 
-            git_worktree_add_options options = new git_worktree_add_options
+            var options = new git_worktree_add_options
             {
                 version = 1,
                 locked = Convert.ToInt32(isLocked)
@@ -81,20 +80,18 @@ public virtual Worktree Add(string committishOrBranchSpec, string name, string p
                 }
             }
 
-
-
             return this[name];
         }
 
         /// <summary>
-        ///
+        /// Creates a worktree.
         /// </summary>
-        /// <param name="name"></param>
-        /// <param name="path"></param>
+        /// <param name="name">Name of the worktree.</param>
+        /// <param name="path">Location of the worktree.</param>
         /// <param name="isLocked"></param>
         public virtual Worktree Add(string name, string path, bool isLocked)
         {
-            git_worktree_add_options options = new git_worktree_add_options
+            var options = new git_worktree_add_options
             {
                 version = 1,
                 locked = Convert.ToInt32(isLocked)