Allow Configuration of it-length-prefixed MAX_DATA_LENGTH via PeerStreams Options

[justin0mcateer]

The PeerStreams class does not configure and does not allow for configuration of the it-length-prefixed 'decode' function. This causes it-length-prefixed to default to 4 MB (4 * 1024 * 1024). Sending messages over this size succeeds without issue. When the receiving side starts to decode the transmitted data, it throws if the encoded length is over 4MB.

• Version:
  2.3.1

• Platform:
  Linux master 6.11.6-arch1-1 #1 SMP PREEMPT_DYNAMIC Fri, 01 Nov 2024 03:30:41 +0000 x86_64 GNU/Linux
Brave Browser 130.1.71.123

• Subsystem:
  pubsub

Severity:

Medium

Description:

Sending large messages using the PeerStreams class

Steps to reproduce the error:

Send any message over 4 megabytes (4 * 1024 * 1024).
Observe there is no error on the sending side
Observe the receiving side throws an error and does not receive the message.

[achingbrain]

Makes sense - please can you submit a PR with a test?

[acul71]

@SgtPooki @achingbrain Will work on this when alanshaw/it-length-prefixed#136 will be merged

[cedrickah]

Hello @achingbrain @SgtPooki. I'm still getting familiar with the project but working on this might be a good step for me. I am available to do so as soon as it is merged .

[acul71]

Hello @achingbrain @SgtPooki. I'm still getting familiar with the project but working on this might be a good step for me. I am available to do so as soon as it is merged .

Hello @cedrick-ah I'm already working on this issue, indeed I've submitted a PR for this issue alanshaw/it-length-prefixed#136 that will enable me to complete the work once merged

[cedrickah]

Okay. Thank you @acul71 for the reply.

[achingbrain]

alanshaw/it-length-prefixed#136 has been merged and shipped in it-length-prefixed@10.0.0 so this is now unblocked.

[acul71]

@achingbrain @SgtPooki It could be close, it has been fixed by #2954