Potential higher compatibility option in command with TAB plugin; nametags

[MotikaCraft-TheJoshua]

So, basically, some option like usingTAB with boolean value, where the default value (if usingTAB option is not present in command) is false, assuming you must enter this option and set it to true to actually confirm you want TAB plugin to handle nametags

How will this work:
/disguise player "SomeRandomUsername123" setSkin Notch usingTAB true

So now when you execute this command, if the usingTAB option is present and functional in plugin, it will let TAB plugin control nametags, fully, even for handling when player is entering a vehicles (mentioning this because i recently reported a bug related to vehicles that TAB plugin similarly/exactly fixes to what i suggested in #741)

Basically - nametag compatibility with TAB, where TAB plugin will have priority in nametags if this option is present and set to true.

[MotikaCraft-TheJoshua]

@libraryaddict any chance you check this out?

[MotikaCraft-TheJoshua]

Sorry for bothering @libraryaddict, any chance?

[libraryaddict]

Almost marks the third time I forgot to respond.

Anyways is this a global server setting you're looking for? Or did you specifically need it to only work on some disguises but others have normal name tags.

I'm mainly wondering if your use case is already handled by the scoreboard settings, such as changing it to vanilla. Or maybe the armorstand option isn't selected on your server.

I don't think there's a way to control that individually though, which is why I asked the first question. I need to verify if there's a reason that it's not usable on an individual level already, but I believe it's likely because it probably either provides unnecessary overhead or it conflicts on some level with each other. Basically not so performant.

Though a setting that simply controls if nametags are handled or not is simpler yeah, it's also not something I'm too keen on as it's a bad workaround that wants to stick around eternally because it's now being used actively.

[libraryaddict]

So the most likely change on my end is a setting that can be controlled per disguise on the mechanics it uses to display a nametag over the head. But I'm not sure if that's feasible, and I'm not too keen on the work to do it as it feels really niche. A setting of turning off handling would make more sense, but as I did say, it feels hacky.

[MotikaCraft-TheJoshua]

I'll explain in my case why i think this feature should really be added, but i think anyone who will use libsdisguises and tab plugin or any plugin that customizes nametag (above head) will probably think the same as i genuinely think it's reasonable

I am not so technical to know what is possible here (like if it must be global setting to disable LibsDisguise overriding with custom nametag content)

i will give example of a command i use to disguise (i actually have something similar to this on player join for certain users just for some random tests)

/disguiseplayer TheJoshua player "&4✪&r &8[&4&oAdmin&8] &4TheJoshua&r" setSkin Notch setUpsideDown

Now, what here is critical is this part after player which in this command goes exactly "&4✪&r &8[&4&oAdmin&8] &4TheJoshua&r" - as this is shown in nametag of the player

So basically, in some way detect that tab is handling player's nametag, or just detect that tab is installed (maybe this is a best way but to do this only if hook with TAB is enabled in LibsDisguises config) and if both is true (tab plugin found and setting running or however you think to handle this is best) = make sure that nametag of player is not overriden by LibsDisguises but kept from TAB

So now no matter what we type in command /disguiseplayer TheJoshua player "HERE", the nametag of player will be kept just like he is not disguised, especially good because now we can use any other plugin that also cancels out TAB's nametag like UnlimitedNameTags plugin which enforces 1.19.4+ display entities to show instead of tab nametag, but you can forget about this because if TAB and LibsDisguises work as intented with this potentially new option, then everything other that hooks with TAB will do also good, probably

Thanks for reading and considering

[libraryaddict]

Sorry I had some trouble reading that, I'm a little tired though. But one thing sticks out, set upside down actually relies specifically on being able to change your nametag to a certain mojang player name. Only when your player disguise has that exact name will it be upside down. To pretend it's not that name, the name is hidden and armorstand is used to show the name on the player disguise instead. This is how it works for all disguises.

I don't recall how tab changes names, but it is almost certain that it would need to hook into libs disguises, or libs disguises to hook into tab. Otherwise tab just doesn't know what name should be given.

Remember, if tab is looking at the real entity then it would never work on anything but actual players, and only for their own names.
If it works on packets, then it probably has no idea that dinnerbone is actually the player Jorge. I don't know how tab works, but basically it's not a simple answer for tab.

Off the top of my head, I know it uses armorstand. I'm guessing it also modifies scoreboard, and names are not calculated on the packet level.

Libs disguises needs to assign scoreboards in order to perform some functions, and this may be unexpected for tab. Or be exactly what tab needs to work but conflicts. Entirely depending on tab to handle it may result in bugs.

So anyways, you're looking to only keep the original name of the player yeah? So you don't expect to have the tab name of other players such as offline. I don't remember exactly but I think tab doesn't handle names as well when you're disguised as it caused two sets of names to appear. Could be an option in its settings and you just need to stop using libs disguises to set names. Or set the name in libs disguises to empty to hide it.

[MotikaCraft-TheJoshua]

TAB v4 used armorstands only when unlimited-nametags option is enabled
It also supported unlimited multiple lines at the same time

However that feature was removed with TAB v5, where it purely relies on native vanilla nametag, only 2 lines (where that lower one is very limited to only value and fixed text...)
However to fix at least for 1.19.4+ clients you can use UnlimitedNametags plugin which for all 1.19.4+ viewers overrides regular TAB nametag and replaces with custom display entities text display entity or whatever it is ..... they work together very well, not double showing anything; and yes i know that since 1.20.3+ (i think) belowname objective can be almost fully customized, it's a good thing too but still limited with number of lines (i am only saying this for anyone who reads this if they need this info and why this is useful)

To not go far away from the topic,

So anyways, you're looking to only keep the original name of the player yeah?

yes, option to not hide or not modify initial nametag by LibsDisguises even if gameprofile of player is set to Dinnerbone (upsidedown) or however it is handled, i am not very technical so i cannot really explain some things with 100% accuracy as i don't know how it actually works, but i assume that when you set player upside down he has that gameprofile of upside down player which is Dinnerbone/Grumm and by that their nametags apply above player head automatically(?) and that's why we cannot override it(?)

Potentially to not even hide nametag visibility as it still needs to be visible for TAB plugin to modify it in their configured way but also not to show that text which you define at /disguiseplayer TheJoshua player "<HERE>"
This could allow us for 2 native lines of nametag shown with vanilla, controlled by TAB (in this case)

[libraryaddict]

Again, have you tested this with vanilla setting in libs disguises configuration

[MotikaCraft-TheJoshua]

Again, have you tested this with vanilla setting in libs disguises configuration

Sorry, which setting specifically?
i executed grep -r "vanilla" inside of libsdisguises config folder if you meant specifically setting called "vanilla" but did not find anything
i maybe you mean default settings? sorry for confusion

I have used libsdisguises only with default configuration, didn't find any option that maybe could do this we are talking about

[libraryaddict]

Libs disguises in scoreboard setting, should be displays.yml
Nametags has a comment for vanilla, it's all upper case name

[libraryaddict]

VANILLA

[MotikaCraft-TheJoshua]

I have set it to VANILLA now and reloaded plugin

Plugin version: LibsDisguises version 11.0.5 (not dev build, stable release of premium version)

command used:
/disguiseplayer TheJoshua player "&4✪&r &8[&4&oAdmin&8] &4TheJoshua&r" setSkin TheJoshua setUpsideDown

viewer (1.8 client on 1.21.1 server):

Note:
Is something changed here? because i didn't know it functions like this, it feels very off;
What i mean is that it spawns NPC which follows you... i feel this was already a thing before(?)
https://i.imgur.com/Pdylhsl.gif

read below

[MotikaCraft-TheJoshua]

Sorry, i've just read i should restart server when changing this option you told me to test with VANILLA
After restarting, exactly same behaviour

btw, is this NPC spawning togglable?
found ViewSelfDisguisesDefault, apologizes

[MotikaCraft-TheJoshua]

i think this should be like an attribute setting or whatever it is called
read this command example:

/disguiseplayer TheJoshua player "&4✪&r &8[&4&oAdmin&8] &4TheJoshua&r" setSkin TheJoshua setUpsideDown setTABNametagOverride

if possible on individual-level (per-player), setTABNametagOverride will make sure that (eligible; if permission-based disguise viewing gets implemented #801) viewers will not see LibsDisguises set nametag but TAB's one (LibsDisguise won't even bother with "nametagging" player)

[libraryaddict]

Yes I need to look at what tab needs to work