Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Performance: Reduce Clones #15

Open
6d7a opened this issue Apr 16, 2024 · 0 comments
Open

Performance: Reduce Clones #15

6d7a opened this issue Apr 16, 2024 · 0 comments
Labels
help wanted Extra attention is needed

Comments

@6d7a
Copy link
Member

6d7a commented Apr 16, 2024

Since performance has not been a priority in the compiler's development, the compiler currently clones all over the place. Strings that reference another data type from the module that is compiled are particularly prone to being cloned. These could be easily replaced with Cows or similar borrowing types. Similarly, the map of TopLevelDeclarations is cloned in some places in the validator module.

@6d7a 6d7a added the help wanted Extra attention is needed label Apr 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

1 participant