Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace manual snapshot tests with insta #51

Open
XAMPPRocky opened this issue Oct 18, 2024 · 1 comment
Open

Replace manual snapshot tests with insta #51

XAMPPRocky opened this issue Oct 18, 2024 · 1 comment
Labels
good first issue Good for newcomers help wanted Extra attention is needed

Comments

@XAMPPRocky
Copy link
Contributor

While looking into some of the generated code, and seeing if lazy_static could be replaced with std::sync::LazyLock (it can't currently), I noticed the setup in rasn-compiler-tests. Currently if you make a change to the generated code, every single instance of the tests needs to be manually updated. I think it would be better if these tests were moved to using insta, because that would allow for updating generated tests automatically in a single command and provide better error messages.

https://docs.rs/insta/latest/insta/

@6d7a
Copy link
Member

6d7a commented Nov 13, 2024

Thank you for your idea. insta would indeed be a substantial improvement for the testing setup in rasn-compiler-tests. I'll put it on my list. PRs will be much appreciated.

@6d7a 6d7a added help wanted Extra attention is needed good first issue Good for newcomers labels Nov 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants