fix(build): include theme JSON assets in published dist#80
Merged
Conversation
Bun does not include variable dynamic imports (import(`./themes/${name}.json`))
in the bundle. The published package was missing theme JSON bodies, causing
ThemeProvider to return null and paint a blank TUI.
Copy src/theme/themes to dist/themes alongside README/LICENSE, matching the
pattern already used for eikon assets.
liftaris
approved these changes
May 24, 2026
Contributor
|
🎉 This PR is included in version 1.7.2-dev.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Merged
Contributor
|
🎉 This PR is included in version 1.7.2 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bun does not include variable dynamic imports (import(
./themes/${name}.json)) in the bundle. The published package was missing theme JSON bodies, causing ThemeProvider to return null and paint a blank TUI.Copy src/theme/themes to dist/themes alongside README/LICENSE, matching the pattern already used for eikon assets. Related #79