v3 issues (#630)

* Fix text node destroy race condition
* Fix texture coordinate update flow
* Guard against RTT texture creation while w/h dimension updates race
condition

Author: wouterlucas

src/core/CoreNode.test.ts

@@ -17,9 +17,10 @@
  * limitations under the License.
  */
 
-import { describe, expect, it, vi } from 'vitest';
+import { describe, expect, it } from 'vitest';
 import { CoreNode, type CoreNodeProps, UpdateType } from './CoreNode.js';
 import { Stage } from './Stage.js';
+import { CoreRenderer } from './renderers/CoreRenderer.js';
 import { mock } from 'vitest-mock-extended';
 import { type TextureOptions } from './CoreTextureManager.js';
 import { createBound } from './lib/utils.js';
@@ -78,6 +79,7 @@ describe('set color()', () => {
     defaultTexture: {
       state: 'loaded',
     },
+    renderer: mock<CoreRenderer>() as CoreRenderer,
   });
 
   describe('set color()', () => {

src/core/CoreNode.ts

@@ -1694,6 +1694,12 @@ export class CoreNode extends EventEmitter {
     const coords = this.renderCoords;
     const texture = p.texture || this.stage.defaultTexture;
 
+    // There is a race condition where the texture can be null
+    // with RTT nodes. Adding this defensively to avoid errors.
+    if (texture && texture.state !== 'loaded') {
+      return;
+    }
+
     renderer.addQuad({
       width: p.w,
       height: p.h,
@@ -1780,7 +1786,7 @@ export class CoreNode extends EventEmitter {
 
   set w(value: number) {
     if (this.props.w !== value) {
-      this.textureCoords = undefined;
+      this.updateTextureCoords = true;
       this.props.w = value;
       this.setUpdateType(UpdateType.Local);
 
@@ -1802,7 +1808,7 @@ export class CoreNode extends EventEmitter {
 
   set h(value: number) {
     if (this.props.h !== value) {
-      this.textureCoords = undefined;
+      this.updateTextureCoords = true;
       this.props.h = value;
       this.setUpdateType(UpdateType.Local);
 
@@ -2139,6 +2145,10 @@ export class CoreNode extends EventEmitter {
   }
 
   set zIndex(value: number) {
+    if (this.props.zIndex === value) {
+      return;
+    }
+
     this.props.zIndex = value;
     this.setUpdateType(UpdateType.CalculatedZIndex | UpdateType.Children);
     for (let i = 0, length = this.children.length; i < length; i++) {

src/core/CoreTextNode.ts

@@ -268,7 +268,7 @@ export class CoreTextNode extends CoreNode implements CoreTextNodeProps {
   }
 
   override destroy(): void {
-    if (this._waitingForFont === true) {
+    if (this._waitingForFont === true && this.fontHandler) {
       this.fontHandler.stopWaitingForFont(this.textProps.fontFamily, this);
     }