Skip to content

Commit faa27f2

Browse files
multi: add accounts u --new_balance deprecation
This commit adds a deprecation notice regarding the `accounts update --new_balance` flag. This flag will be removed in the next major release of lit.
1 parent 819b0a5 commit faa27f2

File tree

6 files changed

+21
-6
lines changed

6 files changed

+21
-6
lines changed

cmd/litcli/accounts.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -162,8 +162,8 @@ var updateAccountCommand = cli.Command{
162162
},
163163
cli.Int64Flag{
164164
Name: "new_balance",
165-
Usage: "The new balance of the account; -1 means do " +
166-
"not update the balance.",
165+
Usage: "(deprecated) The new balance of the account; " +
166+
"-1 means do not update the balance.",
167167
Value: -1,
168168
},
169169
cli.Int64Flag{

docs/release-notes/release-notes-0.14.2.md

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -24,6 +24,14 @@
2424
specified amount.
2525

2626
### Technical and Architectural Updates
27+
28+
## RPC Updates
29+
30+
* The [`accounts update` `--new_balance` flag has been
31+
deprecated](https://github.com/lightninglabs/lightning-terminal/pull/974).
32+
Use the `accounts credit` and `accounts debit` commands instead, to update
33+
an account's balance. The flag will no longer be supported in Lightning
34+
Terminal `v0.15.0-alpha`.
2735

2836
## Integrated Binary Updates
2937

litrpc/lit-accounts.pb.go

Lines changed: 2 additions & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

litrpc/lit-accounts.proto

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -144,7 +144,10 @@ message UpdateAccountRequest {
144144
// The ID of the account to update. Either the ID or the label must be set.
145145
string id = 1;
146146

147-
// The new account balance to set. Set to -1 to not update the balance.
147+
/*
148+
Deprecated, use credit or debit command instead. The new account balance to
149+
set. Set to -1 to not update the balance.
150+
*/
148151
int64 account_balance = 2;
149152

150153
/*

litrpc/lit-accounts.swagger.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -156,7 +156,7 @@
156156
"account_balance": {
157157
"type": "string",
158158
"format": "int64",
159-
"description": "The new account balance to set. Set to -1 to not update the balance."
159+
"description": "Deprecated, use credit or debit command instead. The new account balance to\nset. Set to -1 to not update the balance."
160160
},
161161
"expiration_date": {
162162
"type": "string",

proto/lit-accounts.proto

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -144,7 +144,10 @@ message UpdateAccountRequest {
144144
// The ID of the account to update. Either the ID or the label must be set.
145145
string id = 1;
146146

147-
// The new account balance to set. Set to -1 to not update the balance.
147+
/*
148+
Deprecated, use credit or debit command instead. The new account balance to
149+
set. Set to -1 to not update the balance.
150+
*/
148151
int64 account_balance = 2 [jstype = JS_STRING];
149152

150153
/*

0 commit comments

Comments
 (0)