itest: separate tapd logs from itest

Author: darioAnongba

itest/tapd_harness.go

@@ -190,7 +190,7 @@ func newTapdHarness(t *testing.T, ht *harnessTest, cfg tapdConfig,
 	}
 
 	tapCfg := tapcfg.DefaultConfig()
-	tapCfg.LogDir = "."
+	tapCfg.LogDir = *logDir
 	tapCfg.MaxLogFiles = 99
 	tapCfg.MaxLogFileSize = 999
 

itest/test_harness.go

@@ -4,6 +4,7 @@ import (
 	"context"
 	"flag"
 	"fmt"
+	"path/filepath"
 	"testing"
 	"time"
 
@@ -47,6 +48,10 @@ var (
 	// integration test output.
 	logLevel = flag.String("loglevel", "info", "Set the log level of the "+
 		"integration test output")
+
+	// logDir is the directory for tapd and test logs.
+	// We hardcode this to match the Makefile's -logdir=regtest flag.
+	logDir = &[]string{"regtest"}[0]
 )
 
 const (
@@ -201,12 +206,18 @@ func (h *harnessTest) shutdown(_ *testing.T) error {
 func (h *harnessTest) setupLogging() {
 	h.logWriter = build.NewRotatingLogWriter()
 
+	// Initialize the log rotator with a file in the log directory.
 	logConfig := build.DefaultLogConfig()
+	// Disable console logging to avoid mixing with test output
+	logConfig.Console.Disable = true
+	logFile := filepath.Join(*logDir, "tapd.log")
+	err := h.logWriter.InitLogRotator(logConfig.File, logFile)
+	require.NoError(h.t, err)
+
 	h.logMgr = build.NewSubLoggerManager(
 		build.NewDefaultLogHandlers(logConfig, h.logWriter)...,
 	)
 
-	var err error
 	h.interceptor, err = signal.Intercept()
 	require.NoError(h.t, err)
 

itest/zero_value_anchor_test.go

@@ -0,0 +1,134 @@
+package itest
+
+import (
+	"context"
+
+	"github.com/lightninglabs/taproot-assets/taprpc"
+	"github.com/lightninglabs/taproot-assets/taprpc/mintrpc"
+	"github.com/stretchr/testify/require"
+)
+
+// testZeroValueAnchorSweep tests that zero-value anchor outputs (tombstones)
+// are automatically swept when creating new on-chain transactions.
+func testZeroValueAnchorSweep(t *harnessTest) {
+	ctxb := context.Background()
+
+	// First, mint some simple assets.
+	rpcAssets := MintAssetsConfirmBatch(
+		t.t, t.lndHarness.Miner().Client, t.tapd,
+		[]*mintrpc.MintAssetRequest{simpleAssets[0]},
+	)
+
+	genInfo := rpcAssets[0].AssetGenesis
+	assetAmount := simpleAssets[0].Asset.Amount
+
+	// Create a second tapd node.
+	bobLnd := t.lndHarness.NewNodeWithCoins("Bob", nil)
+	secondTapd := setupTapdHarness(t.t, t, bobLnd, t.universeServer)
+	defer func() {
+		require.NoError(t.t, secondTapd.stop(!*noDelete))
+	}()
+
+	// Create an address for Bob to receive ALL assets (full value send).
+	// This should create a tombstone output on Alice's side.
+	bobAddr, err := secondTapd.NewAddr(ctxb, &taprpc.NewAddrRequest{
+		AssetId:      genInfo.AssetId,
+		Amt:          assetAmount, // Send ALL
+		AssetVersion: rpcAssets[0].Version,
+	})
+	require.NoError(t.t, err)
+
+	// Send ALL assets to Bob, which should create a tombstone output.
+	sendResp, _ := sendAssetsToAddr(t, t.tapd, bobAddr)
+
+	// Confirm the send and wait for completion.
+	ConfirmAndAssertOutboundTransfer(
+		t.t, t.lndHarness.Miner().Client, t.tapd, sendResp,
+		genInfo.AssetId,
+		[]uint64{0, assetAmount}, 0, 1,
+	)
+	AssertNonInteractiveRecvComplete(t.t, secondTapd, 1)
+
+	// At this point, Alice should have a tombstone UTXO.
+	// Check Alice's UTXOs to see if there are any without assets (tombstones).
+	aliceUtxos, err := t.tapd.ListUtxos(ctxb, &taprpc.ListUtxosRequest{})
+	require.NoError(t.t, err)
+
+	tombstoneCount := 0
+	for _, utxo := range aliceUtxos.ManagedUtxos {
+		t.t.Logf("UTXO %s has %d assets, value=%d", utxo.OutPoint, len(utxo.Assets), utxo.AmtSat)
+		for _, asset := range utxo.Assets {
+			t.t.Logf("  Asset %x: amount=%d", asset.AssetGenesis.AssetId, asset.Amount)
+		}
+		hasZeroAmountAsset := false
+		for _, asset := range utxo.Assets {
+			if asset.Amount == 0 {
+				hasZeroAmountAsset = true
+				break
+			}
+		}
+		if hasZeroAmountAsset {
+			tombstoneCount++
+			t.t.Logf("Found tombstone UTXO: %s, value=%d",
+				utxo.OutPoint, utxo.AmtSat)
+		}
+	}
+
+	t.t.Logf("Alice has %d tombstone UTXOs before sweep", tombstoneCount)
+	require.Greater(t.t, tombstoneCount, 0, "Should have at least one tombstone UTXO")
+
+	// Now mint more assets for Alice so she can create another transaction
+	// that should sweep the tombstones.
+	rpcAssets2 := MintAssetsConfirmBatch(
+		t.t, t.lndHarness.Miner().Client, t.tapd,
+		[]*mintrpc.MintAssetRequest{simpleAssets[1]},
+	)
+
+	genInfo2 := rpcAssets2[0].AssetGenesis
+	assetAmount2 := simpleAssets[1].Asset.Amount
+
+	// Create another address for Bob.
+	bobAddr2, err := secondTapd.NewAddr(ctxb, &taprpc.NewAddrRequest{
+		AssetId:      genInfo2.AssetId,
+		Amt:          assetAmount2,
+		AssetVersion: rpcAssets2[0].Version,
+	})
+	require.NoError(t.t, err)
+
+	// Send the new assets. This should sweep Alice's tombstone UTXOs.
+	sendResp2, _ := sendAssetsToAddr(t, t.tapd, bobAddr2)
+
+	// Confirm the send.
+	ConfirmAndAssertOutboundTransfer(
+		t.t, t.lndHarness.Miner().Client, t.tapd, sendResp2,
+		genInfo2.AssetId,
+		[]uint64{0, assetAmount2}, 1, 2,
+	)
+	AssertNonInteractiveRecvComplete(t.t, secondTapd, 2)
+
+	// Check Alice's UTXOs again. The tombstones should have been swept.
+	finalAliceUtxos, err := t.tapd.ListUtxos(ctxb, &taprpc.ListUtxosRequest{})
+	require.NoError(t.t, err)
+
+	finalTombstoneCount := 0
+	for _, utxo := range finalAliceUtxos.ManagedUtxos {
+		hasZeroAmountAsset := false
+		for _, asset := range utxo.Assets {
+			if asset.Amount == 0 {
+				hasZeroAmountAsset = true
+				break
+			}
+		}
+		if hasZeroAmountAsset {
+			finalTombstoneCount++
+			t.t.Logf("Found tombstone UTXO after sweep: %s, value=%d",
+				utxo.OutPoint, utxo.AmtSat)
+		}
+	}
+
+	t.t.Logf("Alice has %d tombstone UTXOs after sweep", finalTombstoneCount)
+
+	// We expect no tombstones after the sweep transaction.
+	require.Equal(t.t, 0, finalTombstoneCount,
+		"All tombstones should be swept")
+}