Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support never reading in the file #1184

Open
simon-tma opened this issue May 28, 2019 · 0 comments
Open

Support never reading in the file #1184

simon-tma opened this issue May 28, 2019 · 0 comments
Labels
Level: Enhancement ✨ This item involves an enhancement to existing functionality.

Comments

@simon-tma
Copy link
Contributor

Is your feature request related to a problem? Please describe.
When processing large images, they can cause PHP to run out of memory as the image file is read in as a binary string.

Describe the solution you'd like
When using entirely external commands (e.g. imagick, pngquant, etc), never read the file into memory but work exclusively with temp files.

Basically, I'd like

    $binary = new FileBinary($file->getRealPath(), $type, $ext);
    $newBin = $this->filterManager->applyFilter($binary, 'prepare');

to have $newBin be another FileBinary. This could also be extended to the media/cache endpoint, allowing for its FlySystem integration to use ->writeStream when uploading.

@dbu dbu added the Level: Enhancement ✨ This item involves an enhancement to existing functionality. label Oct 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Level: Enhancement ✨ This item involves an enhancement to existing functionality.
Projects
None yet
Development

No branches or pull requests

2 participants