You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
to do the cleanup changes, rector sounds like the right tool. about adding the configuration: could we enable some rules in php-cs-fixer to detect incomplete property types rather than adding another tool into the CI?
I'd like to see the rector file in the repo, as it's not part of the CI. It will make it easier as rector as more rules for us to adjust to what we use. Especially as we drop support for older versions as they reach EOL.
switch all classes and interfaces to return type declarations over
@return
and parameter&property type declarations.this means bumping the minimum PHP version to 7.4. imo this is worth it.
at the same time, make everything we can final and methods private over protected, unless they are explicitly meant as extension points.
The text was updated successfully, but these errors were encountered: