Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

type declarations #1415

Open
dbu opened this issue Nov 4, 2021 · 3 comments
Open

type declarations #1415

dbu opened this issue Nov 4, 2021 · 3 comments
Milestone

Comments

@dbu
Copy link
Member

dbu commented Nov 4, 2021

switch all classes and interfaces to return type declarations over @return and parameter&property type declarations.

this means bumping the minimum PHP version to 7.4. imo this is worth it.

at the same time, make everything we can final and methods private over protected, unless they are explicitly meant as extension points.

@dbu dbu added this to the 3.0.0 milestone Nov 4, 2021
@stephanvierkant
Copy link

I'll work on this! I'll use Rector for this. Should I add the config to the repository or not?

@dbu
Copy link
Member Author

dbu commented Dec 7, 2021

thanks for offering to help!

to do the cleanup changes, rector sounds like the right tool. about adding the configuration: could we enable some rules in php-cs-fixer to detect incomplete property types rather than adding another tool into the CI?

@tacman
Copy link
Contributor

tacman commented Feb 9, 2022

I'd like to see the rector file in the repo, as it's not part of the CI. It will make it easier as rector as more rules for us to adjust to what we use. Especially as we drop support for older versions as they reach EOL.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants