You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Hello @efeg ,
I just installed the latest version - v0.1.4 and executed ./gradlew jar copyDependantLibs command to generate the jar file. However, when I look under cruise-control-metrics-reporter/build/libs/, I see the jar file named as cruise-control-metrics-reporter-0.1.0-SNAPSHOT.jar.
This is kind of misleading as anyone who comes in later to check the version, will be forced to believe that we're on a very old version.
Would you please fix this?
The text was updated successfully, but these errors were encountered:
Hi @jmarkan ,
Thank you for reporting the issue. I was able to reproduce the problem and seems like all the jars (cruise-control-core, cruise-control-metrics-reporter & cruise-control) are generated with the same version tag (0.1.0-SNAPSHOT.jar). The actual issue is with using the semantic-build-versioning Gradle plugin which relies on the Git tag to create generate the tag version. Currently, already you have to git init to build the jar (ref #256 ) along with this if you run git add . && git commit -m "first commit" && git tag -a 0.1.4 -m "test version" you will be able to generate the jar with 0.1.4 version.
Until then I will explore some better options of embedding the version number or use other Gradle versioning plugin for cruise control.
the kafka project gradle.properties has
version=2.1.0-SNAPSHOT
i like that because I can rename SNAPSHOT to the current short SHA if i'm testing a prerelease. If you're in there modifying this, having the ability for a semver prerelease version would be great, either manual or automatic.
Hello @efeg ,
I just installed the latest version - v0.1.4 and executed
./gradlew jar copyDependantLibs
command to generate the jar file. However, when I look undercruise-control-metrics-reporter/build/libs/
, I see the jar file named as cruise-control-metrics-reporter-0.1.0-SNAPSHOT.jar.This is kind of misleading as anyone who comes in later to check the version, will be forced to believe that we're on a very old version.
Would you please fix this?
The text was updated successfully, but these errors were encountered: