Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Metrics reporter jar file with incorrect version in its name #303

Open
jmarkan opened this issue Aug 21, 2018 · 2 comments
Open

Metrics reporter jar file with incorrect version in its name #303

jmarkan opened this issue Aug 21, 2018 · 2 comments
Assignees
Labels
usability Improves the ease of use or learnability of the system.

Comments

@jmarkan
Copy link

jmarkan commented Aug 21, 2018

Hello @efeg ,
I just installed the latest version - v0.1.4 and executed ./gradlew jar copyDependantLibs command to generate the jar file. However, when I look under cruise-control-metrics-reporter/build/libs/, I see the jar file named as cruise-control-metrics-reporter-0.1.0-SNAPSHOT.jar.

This is kind of misleading as anyone who comes in later to check the version, will be forced to believe that we're on a very old version.

Would you please fix this?

@abhishekmendhekar
Copy link
Contributor

Hi @jmarkan ,
Thank you for reporting the issue. I was able to reproduce the problem and seems like all the jars (cruise-control-core, cruise-control-metrics-reporter & cruise-control) are generated with the same version tag (0.1.0-SNAPSHOT.jar). The actual issue is with using the semantic-build-versioning Gradle plugin which relies on the Git tag to create generate the tag version. Currently, already you have to git init to build the jar (ref #256 ) along with this if you run git add . && git commit -m "first commit" && git tag -a 0.1.4 -m "test version" you will be able to generate the jar with 0.1.4 version.

Until then I will explore some better options of embedding the version number or use other Gradle versioning plugin for cruise control.

@brettrann
Copy link

the kafka project gradle.properties has
version=2.1.0-SNAPSHOT

i like that because I can rename SNAPSHOT to the current short SHA if i'm testing a prerelease. If you're in there modifying this, having the ability for a semver prerelease version would be great, either manual or automatic.

@efeg efeg added the usability Improves the ease of use or learnability of the system. label May 21, 2019
@efeg efeg removed the enhancement label Dec 31, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
usability Improves the ease of use or learnability of the system.
Projects
None yet
Development

No branches or pull requests

4 participants