Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dryrun requests also going through review process #626

Open
nareshv opened this issue Apr 1, 2019 · 0 comments
Open

Dryrun requests also going through review process #626

nareshv opened this issue Apr 1, 2019 · 0 comments
Labels
usability Improves the ease of use or learnability of the system.

Comments

@nareshv
Copy link
Contributor

nareshv commented Apr 1, 2019

git: f3c4839

Is it required to have the dry-run requests also go through the review process ?

Example on my dev env:

http://127.0.0.1:8090/kafkacruisecontrol/add_broker?dryrun=true
		&brokerid=3
		&json=true

Response

{
  "RequestInfo": [
    {
      "Status": "PENDING_REVIEW",
      "SubmissionTimeMs": 1554088218710,
      "SubmitterAddress": "127.0.0.1",
      "Id": 0,
      "EndpointWithParams": "ADD_BROKER?json=true&brokerid=3&dryrun=true",
      "Reason": "Awaiting review."
    }
  ],
  "version": 1
}
@efeg efeg added the usability Improves the ease of use or learnability of the system. label May 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
usability Improves the ease of use or learnability of the system.
Projects
None yet
Development

No branches or pull requests

2 participants