flip the conditional check just in case InstanceGeneration doesn't get set for existing LinodeMachines

Author: AshleyDumaine

internal/controller/linodemachine_controller.go

@@ -791,13 +791,7 @@ func (r *LinodeMachineReconciler) reconcileFirewallID(ctx context.Context, logge
 	)
 	// Get the instance's firewalls normally if this is not using the new linode interfaces,
 	// otherwise we have to get firewalls per linode interface
-	if machineScope.LinodeMachine.Spec.InterfaceGeneration == linodego.GenerationLegacyConfig {
-		firewalls, err = machineScope.LinodeClient.ListInstanceFirewalls(ctx, instanceID, nil)
-		if err != nil {
-			logger.Error(err, "Failed to list firewalls for Linode instance")
-			return ctrl.Result{RequeueAfter: reconciler.DefaultMachineControllerWaitForRunningDelay}, nil
-		}
-	} else {
+	if machineScope.LinodeMachine.Spec.InterfaceGeneration == linodego.GenerationLinode {
 		interfaces, err := machineScope.LinodeClient.ListInterfaces(ctx, instanceID, nil)
 		if err != nil {
 			logger.Error(err, "Failed to list interfaces for Linode instance")
@@ -811,6 +805,12 @@ func (r *LinodeMachineReconciler) reconcileFirewallID(ctx context.Context, logge
 			}
 			firewalls = append(firewalls, ifaceFWs...)
 		}
+	} else {
+		firewalls, err = machineScope.LinodeClient.ListInstanceFirewalls(ctx, instanceID, nil)
+		if err != nil {
+			logger.Error(err, "Failed to list firewalls for Linode instance")
+			return ctrl.Result{RequeueAfter: reconciler.DefaultMachineControllerWaitForRunningDelay}, nil
+		}
 	}
 
 	attachedFWIDs := make([]int, 0, len(firewalls))