Skip to content

Conversation

@itsXuSt
Copy link
Contributor

@itsXuSt itsXuSt commented Dec 25, 2024

In some file systems, path file attribute lookups will be delayed in
returning if you immediately enter a device that has just been
formatted. And because of this, some actions in context menu is disabled
due to the real read write permission is not obtained when context menu
triggered.
Auto mount after formatted, so that there could be a large interval user
first enter into device, and the permission attributes could be updated
correctly.

Log: as above.

Bug: https://pms.uniontech.com/bug-view-296699.html

In some file systems, path file attribute lookups will be delayed in
returning if you immediately enter a device that has just been
formatted. And because of this, some actions in context menu is disabled
due to the real read write permission is not obtained when context menu
triggered.
Auto mount after formatted, so that there could be a large interval user
first enter into device, and the permission attributes could be updated
correctly.

Log: as above.

Bug: https://pms.uniontech.com/bug-view-296699.html
@deepin-ci-robot
Copy link

deepin pr auto review

关键摘要:

  • mainwindow.cpp文件中,QTimer::singleShot(0, this, [this] { ... });的使用可能会导致不必要的延迟,应该考虑是否有更合适的方法来实现设备格式化后的自动挂载。
  • UDisksBlock(this->m_formatPath)->mount({});调用中,mount方法的参数为空,可能需要确认是否有必要传递空参数,或者是否应该传递特定的挂载选项。

是否建议立即修改:

  • 是,建议立即修改以避免潜在的延迟问题和挂载参数的问题。

@github-actions
Copy link

TAG Bot

TAG: 0.0.1.17
EXISTED: no
DISTRIBUTION: unstable

@deepin-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: itsXuSt, liyigang1, max-lvs

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@itsXuSt
Copy link
Contributor Author

itsXuSt commented Dec 25, 2024

/merge

@deepin-bot deepin-bot bot merged commit f3a97d8 into linuxdeepin:master Dec 25, 2024
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants