-
Notifications
You must be signed in to change notification settings - Fork 48
fix: remove left/right margin for dock-network-plugin #467
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
移除托盘网络插件 tooltip 左右两侧的 10px 空白 PMS: BUG-326409 Log:
Reviewer's guide (collapsed on small PRs)Reviewer's GuideRemoves the extra horizontal padding from the dock network plugin tooltip label and cleans up an unused, non-buildable dock example plugin by dropping its CMake integration and source files. Flow diagram for updated CMake plugin subdirectoriesflowchart TD
RootCMake[CMake_root]
DockNetwork[dock_network_plugin]
DSSNetwork[dss_network_plugin]
NetworkService[network_service_plugin]
RootCMake --> DockNetwork
RootCMake --> DSSNetwork
RootCMake --> NetworkService
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
deepin pr auto review我来帮你分析这段代码变更。这是一个删除了dock-example目录并修改了netstatus.cpp的git diff。让我从几个方面来分析:
改进建议:
// 建议添加注释说明修改原因
m_tipsLabel->setContentsMargins(0, 0, 0, 0); // 移除边距以优化显示效果
# 建议添加注释说明移除原因
# dock-example is a test directory and not needed in production
# add_subdirectory("dock-example")
这些修改整体上是合理的,主要是清理了不需要的测试代码,并做了一个小的UI调整。建议在后续开发中保持代码库的整洁,避免将测试代码混入生产代码中。 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey - I've left some high level feedback:
- Since the tooltip is reverting to zero content margins, consider whether you can just remove the
setContentsMarginscall entirely (letting the default style decide padding) or confirm that padding isn’t better handled at the layout/container level instead of the label itself, to avoid overly tight text against the tooltip border.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- Since the tooltip is reverting to zero content margins, consider whether you can just remove the `setContentsMargins` call entirely (letting the default style decide padding) or confirm that padding isn’t better handled at the layout/container level instead of the label itself, to avoid overly tight text against the tooltip border.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: BLumia, caixr23 The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
移除托盘网络插件 tooltip 左右两侧的 10px 空白
同时删除未参与构建且无法顺利构建的 dock 插件示例
Summary by Sourcery
Remove extra horizontal padding from the dock network plugin tooltip and clean up unused dock example plugin sources.
Bug Fixes:
Chores: