[email protected]: Added an option for extra reminders before prayer time #8004
+59
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
I haven't tested but looks OK. |
Author
I did test it, and it was a bit of a pain to change the time back and forth. But it works. I will start testing on my machine as I do on a day to day basis. Just for to be very sure. |
Author
|
Update: Works just as intended |
rcalixte
requested changes
Dec 6, 2025
Comment on lines
+311
to
+313
| if (diffMinutes == extraReminderTime && extraReminderTime > 0) { | ||
| Main.notify(_(extraReminderTime + " Minutes untill " + this._timeNames[nearestPrayerId])); | ||
| } |
Member
There was a problem hiding this comment.
A few things here:
- This string should be translatable since it is user facing.
- How does this condition work if the machine goes to hibernate? Will it send on resume if the limit hits during that time? Should it?
- Later in this file, some whitespace was modified that can probably be reverted while making other changes in this file. Please try to be mindful.
Thank you!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.