Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request: Add tags to domains #143

Open
ShawnPConroy opened this issue Oct 26, 2024 · 2 comments
Open

Feature Request: Add tags to domains #143

ShawnPConroy opened this issue Oct 26, 2024 · 2 comments
Labels
enhancement New feature or request

Comments

@ShawnPConroy
Copy link
Contributor

It would be very handy to be able to group domains by a tag system. By using a tags database table, tags can be referenced:

Here are two design outlines, if you think either would be useful.

Simply creating a tags table with an id and name. And a linking table domains_tags with domain_id and tag_id. This allows for a domain to be tagged in multiple ways at once. Eg., by customer, by status, or by report-frequency. Such as example.com having tags travel_agency, watch_closely, daily_reports. Or even daily_reports_b if they want the daily reports broken up separately in to different groups separate from client name.

Alternatively, a tags table and a tag_id in the domains table would allow a single tag.

Finally, a filter for domains without a tag in the domains view, if not also reports and summary, would be a great QOL feature.

@liuch
Copy link
Owner

liuch commented Oct 27, 2024

I think it can be realized. We just need to think hard about such issues:

  • Is it really necessary to be able to assign different tags to the same domain?

  • Should tags be common for all users?

  • Who will have the right to assign tags?

  • Maybe something else.

p.s. I'm afraid to imagine how many domains you support for this option to be useful to you...

@liuch liuch added the enhancement New feature or request label Oct 27, 2024
@ShawnPConroy
Copy link
Contributor Author

I had thought of some of those questions, but 'who will have the right to assign tags' threw me for a loop.

p.s. I'm afraid to imagine how many domains you support for this option to be useful to you...

I currently am responsible for 38, and some have subdomains! Many are tiny pamphlet websites or local groups or small businesses. Many don't send any emails at all, but should be watched. I need tags a little less now than before, but it's still very useful, and would help avoid the tedium of editing BASH scripts to send the correct reports. Just use tags.

Who will have the right to assign tags?

I had thought of some of these questions before, but who will assign tags? Stated clearly, that one gave me pause. I would like it if some people managed their own domains. Or to allow friends to use my server to monitor their stuff, if they want. Uour user feature is great. In my mind, this answers the questions!

Users should be able to create their own tags, apply them themselves, and possibly have the same tag name. To get a tag from the cli we would need to specify the tag and the user, if not admin. Since it's possible, two users would create the same tag.

It's also possible two users would be able to watch the same domains, tho I don't know why that would happen, aside from the admin and a client's user.

Is it really necessary to be able to assign different tags to the same domain?

It would be fine if the admin made some tags, applied it, and users were able to see tags and group by tags, and to only have one. But I believe that the trouble to make tags be per user and to multi-tag a domain for each user would be worth it. And would make this script very helpful to anyone with more than a dozen domains, especially if they are only getting in to understand DMARC now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants