-
Notifications
You must be signed in to change notification settings - Fork 42
AC-1596 add translations EPs to 3.7 #1621
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
oliwiapolec
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add info about this to the changelog as well 😌
| | ------------ | -------- | ------------ | ----------------------------- | | ||
| | `group_id` | Yes | `number` | ID of the group | | ||
| | `language` | Yes | `string` | Language identifier | | ||
| | `phrases` | Yes | `object[]` | List of phrases to update | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we have a list of possible fields that can be updated? If we don't we should add it in a similar way like here: https://platform.text.com/docs/management/configuration-api#update-agent
|
|
||
| ### List Translations | ||
|
|
||
| Returns a list of translations. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does it return only those that were edited by the user?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Question remains :D Does it return only those translations that were edited by the user?
| | ------------ | -------- | ------------ | ----------------------------- | | ||
| | `group_id` | Yes | `number` | ID of the group | | ||
| | `language` | Yes | `string` | Language identifier | | ||
| | `phrases` | Yes | `object[]` | List of phrases to update | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| | `phrases` | Yes | `object[]` | List of phrases to update | | |
| | `phrases` | Yes | `object[]` | List of the chat widget phrases to update | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! I've fixed a type to object and I've added a list of examples
|
|
||
| | Parameter | Data type | Notes | | ||
| | --------------- | ------------ | ------------------- | | ||
| | `phrases` | `object[]` | List of phrases | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I will edit this note after clarifying what the method returns 🔜
…o AC-1596-translations
oliwiapolec
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add info about this to the changelog 🙏
|
|
||
| ### List Translations | ||
|
|
||
| Returns a list of translations. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Question remains :D Does it return only those translations that were edited by the user?
| | `Embedded_textarea_placeholder` | Message placeholder | | ||
| | `Offline_message_sent` | Ticket confirmation message | | ||
|
|
||
| The examples given above are illustrative only and do not represent the complete set of supported keys. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| The examples given above are illustrative only and do not represent the complete set of supported keys. |
I'd remove this — if we don't want users to access the rest, this is fine for the docs to just list what we give access to without overexplaining
Release requirements
PR information
What does this PR do? (optional)
Type of change
Deploy preview
The deploy preview link will appear in the checks section below once the build is complete.
Versioning
Pull request titles should comply with the Conventional Commits specification. This is required to update the project's version.