Skip to content

Commit fbe23cc

Browse files
authored
Method names fixes. (#727)
Made the mistake of embedding null handler and hid these issues. Awful mistake.
1 parent 60c1a9a commit fbe23cc

File tree

1 file changed

+3
-5
lines changed

1 file changed

+3
-5
lines changed

room.go

Lines changed: 3 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -187,8 +187,6 @@ type Room struct {
187187
rpcHandlers *sync.Map
188188

189189
lock sync.RWMutex
190-
191-
nullEngineHandler
192190
}
193191

194192
// NewRoom can be used to update callbacks before calling Join
@@ -850,7 +848,7 @@ func (r *Room) OnParticipantDisconnect(rp *RemoteParticipant) {
850848
go r.callback.OnParticipantDisconnected(rp)
851849
}
852850

853-
func (r *Room) OnSpeakersChange(speakerUpdates []*livekit.SpeakerInfo) {
851+
func (r *Room) OnSpeakersChanged(speakerUpdates []*livekit.SpeakerInfo) {
854852
speakerMap := make(map[string]Participant)
855853
for _, p := range r.ActiveSpeakers() {
856854
speakerMap[p.SID()] = p
@@ -886,7 +884,7 @@ func (r *Room) OnSpeakersChange(speakerUpdates []*livekit.SpeakerInfo) {
886884
go r.callback.OnActiveSpeakersChanged(activeSpeakers)
887885
}
888886

889-
func (r *Room) OnConnectionQualityUpdate(updates []*livekit.ConnectionQualityInfo) {
887+
func (r *Room) OnConnectionQuality(updates []*livekit.ConnectionQualityInfo) {
890888
for _, update := range updates {
891889
if update.ParticipantSid == r.LocalParticipant.SID() {
892890
r.LocalParticipant.setConnectionQualityInfo(update)
@@ -949,7 +947,7 @@ func (r *Room) OnLocalTrackUnpublished(msg *livekit.TrackUnpublishedResponse) {
949947
}
950948
}
951949

952-
func (r *Room) OnTranscriptionReceived(transcription *livekit.Transcription) {
950+
func (r *Room) OnTranscription(transcription *livekit.Transcription) {
953951
var (
954952
p Participant
955953
publication TrackPublication

0 commit comments

Comments
 (0)