Post Refactor update to session coordinator #1518
Conversation
| var opts = NavOptions() | ||
| opts.joinParams = .some([ "_interface": .object(object: LiveSessionParameters.platformParams)]) | ||
| opts.action = .replace | ||
| let _ = try await client.navigate(next.last!.url.absoluteString, opts) |
There was a problem hiding this comment.
There is a problem here, core now runs it's own even loop and will take patch and redirect events, these are currently not handled if they are not triggered by a client action. Those events are all pushed through SimpleEventHandler.viewReloadSubject. We need to watch for events that are emitted by server-side events and rectify the navigation path.
the other option is just to call the appropriate client navigation functions wherever we would previously just modify the navigation path.
There was a problem hiding this comment.
I'm not following the specific issue here. Can you provide more detail?
There was a problem hiding this comment.
previously the swiftui client listened on the live view channel for live_reload and other push_navigation type events, then it would modify the LiveSessionCoordinator.NavigationPath and all navigation would happen downstream of checking for changes in the scan block like we do here.
Now that push navigation events are handled opaquely inside core, we need to update the LiveSessionCoordinator.NavigationPath in response to internal events. While the code provided here works, the NavigationPath should be controlled by core, which is the opposite of how it works now.
here are speculative changes that would need to be made to the swiftui client if my refactor landed in it's current state.