Move the LiveSocket and LiveChannel api into one central object.
#289
Conversation
…tive-core into centralize_core merge main into refactor
crates/core/src/styles/mod.rs
Outdated
| @@ -0,0 +1 @@ | |||
|
|
|||
There was a problem hiding this comment.
Hmm. Maybe this was added by accident?
There was a problem hiding this comment.
yeah eventually I want to parse style sheets and send them over FFI. But this is far out.
|
|
||
| // Each test runs in a separate thread and should make requests | ||
| // as if it is an isolated session. | ||
| #[cfg(test)] | ||
| thread_local! { | ||
| static TEST_COOKIE_JAR: Arc<Jar> = Arc::default(); | ||
| pub static TEST_COOKIE_JAR: Arc<Jar> = Arc::default(); |
There was a problem hiding this comment.
This could probably be pub (crate).
There was a problem hiding this comment.
The plan for this PR
- get a working centralized version of the API while keeping the old
LiveSocketone. - run both side by side in as many of the tests as possible to ensure parity - then delete
LiveSocket
the cookie jar will be completely gone by the end of it
| @@ -37,6 +43,7 @@ browser = [ | |||
| # See more keys and their definitions at https://doc.rust-lang.org/cargo/reference/manifest.html | |||
|
|
|||
| [dependencies] | |||
| serde_urlencoded = "0.7.1" | |||
There was a problem hiding this comment.
This can be a optional dependency that's enabled with the liveview-channels feature.
| pub fn init_log(level: LogLevel) { | ||
| INIT_LOG.call_once(|| { | ||
| let env = Env::default(); | ||
| let mut builder = Builder::from_env(env); | ||
| builder | ||
| .format(|buf, record| { | ||
| if record.level() == log::Level::Error { | ||
| writeln!( | ||
| buf, | ||
| "[{}] {} {}:{} - {}", | ||
| record.level(), | ||
| record.target(), | ||
| record.file().unwrap_or("unknown"), | ||
| record.line().unwrap_or(0), | ||
| record.args() | ||
| ) | ||
| } else { | ||
| writeln!( | ||
| buf, | ||
| "[{}] {} - {}", | ||
| record.level(), | ||
| record.target(), | ||
| record.args() | ||
| ) | ||
| } | ||
| }) | ||
| .filter(None, level.into()) | ||
| .try_init() | ||
| .expect("LOG INITIALIZATION FAILED"); | ||
| }); | ||
| } |
There was a problem hiding this comment.
Hmm. Does env logger work on the various platforms? Like, debugging on device kinda requires using oslog. I feel like there was an android one (that I never got working).
There was a problem hiding this comment.
This is just a stub for now. I am going make this module way more configurable, but for testing purposes env log is fine. in the end it will be a multi-log with an env log and platform specific log.
There was a problem hiding this comment.
The other goal here - each platform will want something akin to a developer console. Providing a callback interface for appending to an application developer debug log which can filter out core events, present warnings and diagnostics, is an goal.
| session_data: &Mutex<SessionData>, | ||
| redirect: Option<String>, | ||
| ) -> Result<Arc<LiveChannel>, LiveSocketError> { | ||
| let ws_timeout = std::time::Duration::from_millis(config.websocket_timeout); |
There was a problem hiding this comment.
It doesn't really matter but I'm a fan of use std::time::Duration and such at the top of the file and then Duration::from_millis here and below in join_livereload_channel.
There was a problem hiding this comment.
that is fair
…-native-core into centralize_core
…-native-core into centralize_core
| }; | ||
|
|
||
| let mut buffer = Vec::new(); | ||
| let store_guard = self.store.lock().unwrap(); |
There was a problem hiding this comment.
Hmm. Given that you call this from an impl Drop, you might not wanna have an unwrap.
There was a problem hiding this comment.
that is fair, I'm going to move this out of drop. I thought I was being clever by making this run on clean up - but we pretty much have to run it after every insertion just in case something goes wrong anyways.
This is not ready for review yet. goals are as follows.
LiveSocketandLiveChannelapi's into a singleLiveViewClientobject.LiveViewClientassets_change