Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unable to Reproduce Results on AT-AT-CG-CG #1

Closed
Dreamzz5 opened this issue Jan 20, 2025 · 2 comments
Closed

Unable to Reproduce Results on AT-AT-CG-CG #1

Dreamzz5 opened this issue Jan 20, 2025 · 2 comments

Comments

@Dreamzz5
Copy link

I attempted to run the LSRM model using the exact configuration provided in the README:
CUDA_VISIBLE_DEVICES=0,1,2,3 python -m torch.distributed.launch --nproc_per_node=4 --master_port=1230 run_ddp.py \ --model=Visnorm_shared_LSRMNorm2_2branchSerial \ --molecule AT_AT_CG_CG \ --group_builder rdkit \ --num_interactions=4 --long_num_layers=2 \ --learning_rate=0.0004 --rho_tradeoff 0.001 \ --dropout=0 --hidden_channels 128 \ --gradient_clip \ --calculate_meanstd --otfcutoff 4 \ --short_cutoff_upper 4 --long_cutoff_lower 0 --long_cutoff_upper 9 \ --early_stop --early_stop_patience 500 \ --no_broadcast --batch_size 16 \ --ema_decay 0.999 --dropout 0.1

The training doesn't seem to converge to the reported performance metrics. According to Table 2 in the paper, for the AT-AT-CG-CG molecule (diameter ~24Å, 118 atoms), the expected results are:

Energy prediction (MAE in kcal/mol):

ViSNet-LSRM: 0.1135
ViSNet: 0.1995

Force prediction (MAE in kcal/mol/Å):

ViSNet-LSRM: 0.1063
ViSNet: 0.1563

However, my implementation produces significantly different results:

ViSNet-LSRM: 0.24141 (energy) / 0.17699 (force)
ViSNet: 0.25187 (energy) / 0.18616 (force)

Any guidance or clarification would be greatly appreciated. Thank you!

@liyy2
Copy link
Owner

liyy2 commented Jan 20, 2025

Thank you for your comments! The current version of our code, which we internally refer to as v1, is a previous iteration of our codebase. We will be releasing version v2 soon, featuring better performance and new models such as Equiformer-LSRM. Please stay tuned!

@liyy2
Copy link
Owner

liyy2 commented Feb 10, 2025

hi we have updated the code, please see if this resolve your problem.

@liyy2 liyy2 closed this as completed Feb 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants