Skip to content

add mesh bp rename util#1615

Open
cyrush wants to merge 6 commits into
developfrom
task/2026_05_mesh_bp_rename_util
Open

add mesh bp rename util#1615
cyrush wants to merge 6 commits into
developfrom
task/2026_05_mesh_bp_rename_util

Conversation

@cyrush
Copy link
Copy Markdown
Member

@cyrush cyrush commented May 26, 2026

No description provided.

@cyrush cyrush requested a review from JustinPrivitera May 26, 2026 21:10
Comment thread src/libs/blueprint/conduit_blueprint_mesh.hpp Outdated
Comment on lines +448 to +465
* @verbatim
* options:
* coordsets:
* coords_old : coords_new
* topologies:
* topo_old : topo_new
* fields:
* field_old : field_new
* matsets:
* matset_old : matset_new
* specsets:
* specset_old : specset_new
* adjsets:
* adjset_old : adjset_new
* nestsets:
* nestset_old : nestset_new
*
* @endverbatim
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we ever have multiple things to rename in a given category? Maybe we rename multiple fields?

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks like we can, so should this docstring be updated to make that clearer?

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I should add an example that shows this

  • add example

Comment thread src/tests/blueprint/t_blueprint_mesh_rename.cpp Outdated
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants