Skip to content

Commit c7fd3b9

Browse files
committed
review comments
1 parent 5ffd881 commit c7fd3b9

File tree

2 files changed

+5
-5
lines changed

2 files changed

+5
-5
lines changed

flang/include/flang/Optimizer/Dialect/FIROps.td

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3667,10 +3667,10 @@ def fir_DeclareReductionOp : fir_Op<"declare_reduction", [IsolatedFromAbove,
36673667
let summary = "declares a reduction kind";
36683668
let description = [{
36693669
Note: this operation is adapted from omp::DeclareReductionOp. There is a lot
3670-
duplication at the moment. TODO Combined both ops into one. See:
3670+
duplication at the moment. TODO Combine both ops into one. See:
36713671
https://discourse.llvm.org/t/dialect-for-data-locality-sharing-specifiers-clauses-in-openmp-openacc-and-do-concurrent/86108.
36723672

3673-
Declares an `do concurrent` reduction. This requires two mandatory and three
3673+
Declares a `do concurrent` reduction. This requires two mandatory and three
36743674
optional regions.
36753675

36763676
1. The optional alloc region specifies how to allocate the thread-local

flang/lib/Lower/Bridge.cpp

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -2104,10 +2104,9 @@ class FirConverter : public Fortran::lower::AbstractConverter {
21042104
llvm::SmallVector<mlir::Attribute> reductionDeclSymbols;
21052105
llvm::SmallVector<mlir::Attribute> nestReduceAttrs;
21062106

2107-
for (const auto &reduceOp : info.reduceOperatorList) {
2107+
for (const auto &reduceOp : info.reduceOperatorList)
21082108
nestReduceAttrs.push_back(
21092109
fir::ReduceAttr::get(builder->getContext(), reduceOp));
2110-
}
21112110

21122111
llvm::SmallVector<mlir::Value> reduceVars;
21132112
Fortran::lower::omp::ReductionProcessor rp;
@@ -2543,7 +2542,8 @@ class FirConverter : public Fortran::lower::AbstractConverter {
25432542

25442543
builder->setInsertionPointToEnd(loopWrapperOp.getBody());
25452544
auto loopOp = builder->create<fir::DoConcurrentLoopOp>(
2546-
loc, nestLBs, nestUBs, nestSts, nullptr, /*local_vars=*/std::nullopt,
2545+
loc, nestLBs, nestUBs, nestSts, /*loopAnnotation=*/nullptr,
2546+
/*local_vars=*/std::nullopt,
25472547
/*local_syms=*/nullptr, /*reduce_vars=*/std::nullopt,
25482548
/*reduce_byref=*/nullptr, /*reduce_syms=*/nullptr,
25492549
/*reduce_attrs=*/nullptr);

0 commit comments

Comments
 (0)