Fix some "not all control paths return" warnings; NFC

AaronBallman · AaronBallman · commit ddea4fe85a01 · 2025-06-16T07:51:25.000-04:00
diff --git a/clang-tools-extra/clang-doc/Representation.cpp b/clang-tools-extra/clang-doc/Representation.cpp
@@ -147,6 +147,7 @@ mergeInfos(std::vector<std::unique_ptr<Info>> &Values) {
     return llvm::createStringError(llvm::inconvertibleErrorCode(),
                                    "unexpected info type");
   }
+  llvm_unreachable("unhandled enumerator");
 }
 
 bool CommentInfo::operator==(const CommentInfo &Other) const {
diff --git a/clang-tools-extra/clang-doc/Serialize.cpp b/clang-tools-extra/clang-doc/Serialize.cpp
@@ -392,6 +392,7 @@ std::string serialize(std::unique_ptr<Info> &I) {
   case InfoType::IT_default:
     return "";
   }
+  llvm_unreachable("unhandled enumerator");
 }
 
 static void parseFullComment(const FullComment *C, CommentInfo &CI) {

Original file line number	Diff line number	Diff line change
`@@ -147,6 +147,7 @@ mergeInfos(std::vector<std::unique_ptr<Info>> &Values) {`
`147`	`147`	`return llvm::createStringError(llvm::inconvertibleErrorCode(),`
`148`	`148`	`"unexpected info type");`
`149`	`149`	`}`
	`150`	`+ llvm_unreachable("unhandled enumerator");`
`150`	`151`	`}`
`151`	`152`
`152`	`153`	`bool CommentInfo::operator==(const CommentInfo &Other) const {`
Original file line number	Diff line number	Diff line change
`@@ -392,6 +392,7 @@ std::string serialize(std::unique_ptr<Info> &I) {`
`392`	`392`	`case InfoType::IT_default:`
`393`	`393`	`return "";`
`394`	`394`	`}`
	`395`	`+ llvm_unreachable("unhandled enumerator");`
`395`	`396`	`}`
`396`	`397`
`397`	`398`	`static void parseFullComment(const FullComment *C, CommentInfo &CI) {`