diff --git a/lld/COFF/InputFiles.cpp b/lld/COFF/InputFiles.cpp index 7b105fb4c17a2..beb56d00b7b50 100644 --- a/lld/COFF/InputFiles.cpp +++ b/lld/COFF/InputFiles.cpp @@ -117,6 +117,32 @@ static coff_symbol_generic *cloneSymbol(COFFSymbolRef sym) { } } +// Skip importing DllMain thunks from import libraries. +static bool fixupDllMain(COFFLinkerContext &ctx, llvm::object::Archive *file, + const Archive::Symbol &sym, bool &skipDllMain) { + if (skipDllMain) + return true; + const Archive::Child &c = + CHECK(sym.getMember(), file->getFileName() + + ": could not get the member for symbol " + + toCOFFString(ctx, sym)); + MemoryBufferRef mb = + CHECK(c.getMemoryBufferRef(), + file->getFileName() + + ": could not get the buffer for a child buffer of the archive"); + if (identify_magic(mb.getBuffer()) == file_magic::coff_import_library) { + // We won't place DllMain symbols in the symbol table if they are + // coming from a import library. This message can be ignored with the flag + // '/ignore:exporteddllmain' + Warn(ctx) << file->getFileName() + << ": skipping imported DllMain symbol\nNOTE: this " + "might be a mistake when the DLL/library was produced."; + skipDllMain = true; + return true; + } + return false; +} + ArchiveFile::ArchiveFile(COFFLinkerContext &ctx, MemoryBufferRef m) : InputFile(ctx.symtab, ArchiveKind, m) {} @@ -140,8 +166,17 @@ void ArchiveFile::parse() { } // Read the symbol table to construct Lazy objects. - for (const Archive::Symbol &sym : file->symbols()) + bool skipDllMain = false; + for (const Archive::Symbol &sym : file->symbols()) { + // If the DllMain symbol was exported by mistake, skip importing it + // otherwise we might end up with a import thunk in the final binary which + // is wrong. + if (sym.getName() == "__imp_DllMain" || sym.getName() == "DllMain") { + if (fixupDllMain(ctx, file.get(), sym, skipDllMain)) + continue; + } ctx.symtab.addLazyArchive(this, sym); + } } // Returns a buffer pointing to a member file containing a given symbol. diff --git a/lld/test/COFF/exported-dllmain.test b/lld/test/COFF/exported-dllmain.test new file mode 100644 index 0000000000000..3642d6375cdc0 --- /dev/null +++ b/lld/test/COFF/exported-dllmain.test @@ -0,0 +1,55 @@ +REQUIRES: x86 +RUN: split-file %s %t.dir && cd %t.dir + +RUN: llvm-mc -filetype=obj -triple=x86_64-windows a.s -o a.obj + +RUN: llvm-mc -filetype=obj -triple=x86_64-windows b1.s -o b1.obj +RUN: llvm-mc -filetype=obj -triple=x86_64-windows b2.s -o b2.obj + +### This is the line where our problem occurs. Here, we export the DllMain symbol which shouldn't happen normally. +RUN: lld-link b1.obj b2.obj -out:b.dll -dll -implib:b.lib -entry:DllMain -export:bar -export:DllMain + +RUN: llvm-mc -filetype=obj -triple=x86_64-windows c.s -o c.obj +RUN: lld-link -lib c.obj -out:c.lib + +### Later, if b.lib is provided before other libs/objs that export DllMain statically, we previously were using the dllimported DllMain from b.lib, which is wrong. +RUN: lld-link a.obj b.lib c.lib -dll -out:out.dll -entry:DllMain 2>&1 | FileCheck -check-prefix=WARN %s +RUN: llvm-objdump --private-headers -d out.dll | FileCheck -check-prefix=DISASM %s + +WARN: lld-link: warning: b.lib: skipping imported DllMain symbol + +DISASM: The Import Tables: +DISASM: DLL Name: b.dll +DISASM-NOT: DllMain +DISASM: bar +DISASM: Disassembly of section .text: +DISASM-EMPTY: +DISASM: b8 01 00 00 00 movl $0x1, %eax +DISASM-NEXT: c3 retq + +#--- a.s + .text + .globl foo +foo: + call *__imp_bar(%rip) + ret + +#--- b1.s + .text + .globl bar +bar: + ret + +#--- b2.s + .text + .globl DllMain +DllMain: + xor %eax, %eax + ret + +#--- c.s + .text + .globl DllMain +DllMain: + movl $1, %eax + ret