Skip to content

[clang][bytecode] Fix redeclaring global externs without initializer #164409

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 21, 2025
Merged

[clang][bytecode] Fix redeclaring global externs without initializer #164409

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion clang/lib/AST/ByteCode/Compiler.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4872,7 +4872,7 @@ Compiler<Emitter>::visitVarDecl(const VarDecl *VD, const Expr *Init,

// The previous attempt at initialization might've been unsuccessful,
// so let's try this one.
return Init && checkDecl() && initGlobal(*GlobalIndex);
return !Init || (checkDecl() && initGlobal(*GlobalIndex));
}

UnsignedOrNone GlobalIndex = P.createGlobal(VD, Init);
Expand Down
13 changes: 13 additions & 0 deletions clang/test/AST/ByteCode/builtin-functions.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,6 +63,19 @@ constexpr int test_address_of_incomplete_array_type() { // both-error {{never pr
static_assert(test_address_of_incomplete_array_type() == 1234, ""); // both-error {{constant}} \
// both-note {{in call}}

namespace LocalExternRedecl {
constexpr int externRedecl1() {
extern int arr[];
return 0;
}
constexpr int externRedecl2() { // both-error {{never produces a constant expression}}
extern int arr[];
__builtin_memmove(&arr, &arr, 4 * sizeof(arr[0])); // both-note 2{{incomplete type}}
return 1234;
}
static_assert(externRedecl2() == 1234); // both-error {{not an integral constant expression}} \
// both-note {{in call to}}
}

struct NonTrivial {
constexpr NonTrivial() : n(0) {}
Expand Down